Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Peng Wang" <rocking@whu.edu.cn>
To:     "'Tejun Heo'" <tj@kernel.org>
Cc:     <lizefan@huawei.com>, <hannes@cmpxchg.org>,
        <cgroups@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20190708130132.5582-1-rocking@whu.edu.cn> <20190708144121.GA657710@devbig004.ftw2.facebook.com>
In-Reply-To: <20190708144121.GA657710@devbig004.ftw2.facebook.com>
Subject: RE: [PATCH] cgroup: simplify code for cgroup_subtree_control_write()
Date:   Tue, 9 Jul 2019 09:55:54 +0800
Message-ID: <000301d535f9$71f1ab90$55d502b0$@whu.edu.cn>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Thread-Index: AQE94/eHFYIYcEzptv5v1lkJv7sJaAH+JMagp+A37hA=
Content-Language: zh-cn
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Monday, July 8, 2019 10:41 PM, Tejun Heo wrote:
> On Mon, Jul 08, 2019 at 09:01:32PM +0800, Peng Wang wrote:
> > Process "enable" and "disable" earlier to simplify code.
> 
> I don't think this is correct and even if it were the value of this
> change is close to none, so nack on this one.

OK. 
Although I have tested this patch for common case, It's just somewhat trivial.

Thanks for your time :-).

> 
> Thanks.
> 
> --
> tejun