Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCHv2 4/4] tty: n_gsm: add ioctl to map serial device to
 mux'ed tty
To:     Jiri Slaby <jslaby@suse.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
Cc:     Esben Haabendal <esben@geanix.com>,
        =?UTF-8?Q?Sean_Nyekj=c3=a6r?= <sean@geanix.com>
References: <20190709064633.45411-1-martin@geanix.com>
 <20190709064633.45411-4-martin@geanix.com>
 <97618a78-36e7-f071-47e2-beadbd505cb6@suse.com>
From:   =?UTF-8?Q?Martin_Hundeb=c3=b8ll?= <martin@geanix.com>
Message-ID: <764ab112-0e0d-fa10-607a-6ffb1f53297d@geanix.com>
Date:   Tue, 9 Jul 2019 08:52:22 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <97618a78-36e7-f071-47e2-beadbd505cb6@suse.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US-large
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 09/07/2019 08.49, Jiri Slaby wrote:
> On 09. 07. 19, 8:46, Martin Hundebøll  wrote:
>> @@ -2623,6 +2624,9 @@ static int gsmld_ioctl(struct tty_struct *tty, struct file *file,
>>   		if (copy_from_user(&c, (void *)arg, sizeof(c)))
>>   			return -EFAULT;
>>   		return gsm_config(gsm, &c);
>> +	case GSMIOC_GETBASE:
>> +		base = mux_num_to_base(gsm);
>> +		return put_user(base, (int __user *)arg);
> I am not sure, but do you need the local variable at all?

No, I kept it around just to avoid too many parenthesis in the 
put_user() call.

Your call.

// Martin