Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] tipc: ensure skb->lock is initialised
To:     Chris Packham <Chris.Packham@alliedtelesis.co.nz>,
        Eric Dumazet <eric.dumazet@gmail.com>,
        "jon.maloy@ericsson.com" <jon.maloy@ericsson.com>,
        "ying.xue@windriver.com" <ying.xue@windriver.com>,
        "davem@davemloft.net" <davem@davemloft.net>
Cc:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "tipc-discussion@lists.sourceforge.net" 
        <tipc-discussion@lists.sourceforge.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20190707225328.15852-1-chris.packham@alliedtelesis.co.nz>
 <2298b9eb-100f-6130-60c4-0e5e2c7b84d1@gmail.com>
 <361940337b0d4833a5634ddd1e1896a9@svr-chch-ex1.atlnz.lc>
 <87fd2150548041219fc42bce80b63c9c@svr-chch-ex1.atlnz.lc>
From:   Eric Dumazet <eric.dumazet@gmail.com>
Message-ID: <b862a74b-9f1e-fb64-0641-550a83b64664@gmail.com>
Date:   Tue, 9 Jul 2019 09:30:42 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.1
MIME-Version: 1.0
In-Reply-To: <87fd2150548041219fc42bce80b63c9c@svr-chch-ex1.atlnz.lc>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 7/8/19 11:13 PM, Chris Packham wrote:
> On 9/07/19 8:43 AM, Chris Packham wrote:
>> On 8/07/19 8:18 PM, Eric Dumazet wrote:
>>>
>>>
>>> On 7/8/19 12:53 AM, Chris Packham wrote:
>>>> tipc_named_node_up() creates a skb list. It passes the list to
>>>> tipc_node_xmit() which has some code paths that can call
>>>> skb_queue_purge() which relies on the list->lock being initialised.
>>>> Ensure tipc_named_node_up() uses skb_queue_head_init() so that the lock
>>>> is explicitly initialised.
>>>>
>>>> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
>>>
>>> I would rather change the faulty skb_queue_purge() to __skb_queue_purge()
>>>
>>
>> Makes sense. I'll look at that for v2.
>>
> 
> Actually maybe not. tipc_rcast_xmit(), tipc_node_xmit_skb(), 
> tipc_send_group_msg(), __tipc_sendmsg(), __tipc_sendstream(), and 
> tipc_sk_timeout() all use skb_queue_head_init(). So my original change 
> brings tipc_named_node_up() into line with them.
> 
> I think it should be safe for tipc_node_xmit() to use 
> __skb_queue_purge() since all the callers seem to have exclusive access 
> to the list of skbs. It still seems that the callers should all use 
> skb_queue_head_init() for consistency.
> 

No, tipc does not use the list lock (it relies on the socket lock)
 and therefore should consistently use __skb_queue_head_init()
instead of skb_queue_head_init()

Using a spinlock to protect a local list makes no sense really,
it spreads false sense of correctness.

tipc_link_xmit() for example never acquires the spinlock,
yet uses skb_peek() and __skb_dequeue()

It is time to clean all this mess.