Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190709115759.10451-1-chris.redpath@arm.com> <20190709135054.GF3402@hirez.programming.kicks-ass.net>
 <b0d82dbf-f23b-f858-4c60-b5a413c0e618@arm.com> <CAKfTPtCxw8Xqz3rJPKeeDVfvWTcsByAb64_JtB-w2Bp83BGBgw@mail.gmail.com>
 <1128a866-6817-3703-8962-8c3670dd10c1@foss.arm.com>
In-Reply-To: <1128a866-6817-3703-8962-8c3670dd10c1@foss.arm.com>
From:   Vincent Guittot <vincent.guittot@linaro.org>
Date:   Tue, 9 Jul 2019 17:46:18 +0200
Message-ID: <CAKfTPtD3j6M5q1feDMQ3S7=YVwL7BJ2ShHcki777Xx2sHbD+_w@mail.gmail.com>
Subject: Re: [PATCH] sched/fair: Update rq_clock, cfs_rq before migrating for
 asym cpu capacity
To:     Chris Redpath <chris.redpath@arm.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@redhat.com>,
        Morten Rasmussen <Morten.Rasmussen@arm.com>,
        Dietmar Eggemann <Dietmar.Eggemann@arm.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 9 Jul 2019 at 17:42, Chris Redpath <chris.redpath@foss.arm.com> wrote:
>
> On 09/07/2019 16:36, Vincent Guittot wrote:
> > Hi Chris,
> >
> >>
> >> We enter this code quite often in our testing, most individual runs of a
> >> test which has small tasks involved have at least one hit where we make
> >> a change to the clock with this patch in.
> >
> > Do you have a rt-app file that you can share ?
> >
>
> The ThreeSmallTasks test which is the worst hit produces this:
>
> {
>      "tasks": {
>          "small_0": {
>              "policy": "SCHED_OTHER",
>              "delay": 0,
>              "loop": 1,
>              "phases": {
>                  "p000001": {
>                      "loop": 62,
>                      "run": 2880,
>                      "timer": {
>                          "ref": "small_0",
>                          "period": 16000
>                      }
>                  }
>              }
>          },
>          "small_1": {
>              "policy": "SCHED_OTHER",
>              "delay": 0,
>              "loop": 1,
>              "phases": {
>                  "p000001": {
>                      "loop": 62,
>                      "run": 2880,
>                      "timer": {
>                          "ref": "small_1",
>                          "period": 16000
>                      }
>                  }
>              }
>          },
>          "small_2": {
>              "policy": "SCHED_OTHER",
>              "delay": 0,
>              "loop": 1,
>              "phases": {
>                  "p000001": {
>                      "loop": 62,
>                      "run": 2880,
>                      "timer": {
>                          "ref": "small_2",
>                          "period": 16000
>                      }
>                  }
>              }
>          }
>      },
>      "global": {
>          "default_policy": "SCHED_OTHER",
>          "duration": -1,
>          "calibration": 264,
>          "logdir": "/root/devlib-target"
>      }
> }
>
> when I run it

Thanks I will make it a try on my b.L platform

>
> >>
> >> That said - despite the relatively high number of hits only about 5% of
> >> runs see enough additional energy consumed to trigger a test failure. We
> >> do try to keep a quiet system as much as possible and only run for a few
> >> seconds so the impact we see in testing is also probably higher than in
> >> the real world.
> >
> > Yeah, I'm curious to see the impact on a real system which have a
> > 60fps screen update like an android phone
> >
>
> I wouldn't expect much change there but I would on the idle-ish
> homescreen/day-of-use type benchmarks.
>
> If I had a platform with any kind of representative energy use, I'd test
> it :)