Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp8395448ybi; Tue, 9 Jul 2019 15:00:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqyCkOuKgtat00BEslTLKsngb79y/CiKhR2AKJueYp8Xp5D8SrWVjypPLo94olRfB+kaXOYT X-Received: by 2002:a63:f941:: with SMTP id q1mr33402639pgk.350.1562709634316; Tue, 09 Jul 2019 15:00:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562709634; cv=none; d=google.com; s=arc-20160816; b=JbvWpGfM5x+6nti6fwF99PV9Q6tJg5w6c8LIjnQaNZyOKwObxhJ8S6KPZ2pL6x4KHh dviD+/A8/r5z45TlpIcifBT/L2JQIhtz8Dv+AR33lbllQhWNs21O4DX+gQWg+P6JKpc1 c6j3UN93Bdl/SWyBXt8ifAH6OeD1XuDRkifMMb33/pFP9yWJVUh35R2PNh1zqVWURCEP PcYnqvEJOSES3ivV/hu/R6FowCa/2zNX+IQPbPeJn+iLnZWcDOf8wEtEqOeXzyDoKHWx +nbTUzk9fQ0tvZe+v60OEFzFbYE6aPftRzyOMQr6sHUQQpovkRjR9OPsiA51eJhtSBYg MrNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=vY9MF4vsQOlRvniAiNaBsFH6VbbpILxgqjZN/76Wf38=; b=CXZPHi6NeGCrNZNI+BQ0lU9/nya/iu70x7lQbxKeYpWEnQ/M4bqiSgSAx8aZlHGxrp 8P7MsMIdFIvus6Zaivz+zj/eNUM45ntPUae5RU8je0vlW+p3g/teqm8HSMvCHzzHkfkG aRYHqPg1fBgDBos1mgNh4NGKI4l9Jm4fEqQBitVU4Jb3fxzd2IJ4YMX2MG8e85dZxkYe V//HzG6CYoRxVZTw5g5+UcQ7NVQyRyKcnOCZ+6fUqcSIFVZx6yALwY5U9J0c3G76oQ9T sWCOaFDB228yJqBoSA9NAGM4zEJ3JQgh7MYl5KuxqfLtuMt9FIjyadfGmOKnnCT8JJmV lFpg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z14si147685plo.104.2019.07.09.15.00.19; Tue, 09 Jul 2019 15:00:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729661AbfGIVwn (ORCPT + 99 others); Tue, 9 Jul 2019 17:52:43 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:46262 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727026AbfGIVwn (ORCPT ); Tue, 9 Jul 2019 17:52:43 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 807CC1425B0FD; Tue, 9 Jul 2019 14:52:42 -0700 (PDT) Date: Tue, 09 Jul 2019 14:52:41 -0700 (PDT) Message-Id: <20190709.145241.634478641391763394.davem@davemloft.net> To: suratiamol@gmail.com Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [PATCH] ide: use BIT() macro for defining bit-flags From: David Miller In-Reply-To: <20190707085729.GA22964@arch> References: <20190707085729.GA22964@arch> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 09 Jul 2019 14:52:42 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Amol Surati Date: Sun, 7 Jul 2019 14:27:29 +0530 > The BIT() macro is available for defining the required bit-flags. > > Since it operates on an unsigned value and expands to an unsigned result, > using it, instead of an expression like (1 << x), also fixes the problem > of shifting a signed 32-bit value by 31 bits (e.g. 1 << 31). > > Signed-off-by: Amol Surati Applied, thank you.