Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp8517310ybi; Tue, 9 Jul 2019 17:42:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqx1/JLpVOgr7KxNPnvC/atQIjyNXBOHC7So7tepTDmZnTzxxS/jNPfps4tpgE6elUUr7a5A X-Received: by 2002:a63:30c6:: with SMTP id w189mr32567620pgw.398.1562719376611; Tue, 09 Jul 2019 17:42:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562719376; cv=none; d=google.com; s=arc-20160816; b=lGVqmYFgvm3JTnidWUkuZXrZ0sx8WOTPeR8hd2vUtTImZq24vqvqUHHoMJz6ub8bzz e6KEcZ5rvgocdmixmjEyspowamjt0vO35NrDRr03BWAUU3PmlNJj0sL2L/AgyY4QzSFH i6fqXDzEZ0XQWDcO0TkUIfxQp5lkHm93ND3Yi0guDjnkSvbKg/X12Bq5QQHDxJ9rGF9x 2Uc0e5MNV0AjzY7hH8T7FJ0kzq92hiKpjOrcyoPsmEkmdnvCdHJBpZjb60iw17MDgO9l 9iVqwOdaXKG9Vc6NRlkpzt+h+Zp315AtgQiAD66MUH8sn00sMGYcRnW0JsSz0xQC43SP jxWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=F1YEfnrX5gkf5eSCFBBgYDnY9VrRZyGi7EMYFBwhLqA=; b=Ohh2265sUloYNhyxgAFDs6lKs5wT8G79Q6cXLi5csybuelz1+GzId2R3qs8kleaEuu P61I/3oawt68xje+qyQ4LS9FDEkGUf9w94/mqgbb8aP2o1ocvo+IUP9b3bvzLB7mNKK8 HZWSLGnED1DIJSRsUQ3Z828/y6cGg7QrAm6OVyjfFisnHQS8YYdaxrjFTlRPZIN0/ate nAEfo6IDLj5Jyf8r293OiBGq6jAyQvfem+wz76Ks/EPaW5evawfO/v76MNqyhMYORUlT bllNiasM/x/wIGmn7zLycxe+SNJo95fhq4o0JtD3RsOvqRluKf1tHC7pJm4NQAbLRdER SwBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bcORr81N; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i32si552269pje.44.2019.07.09.17.42.41; Tue, 09 Jul 2019 17:42:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bcORr81N; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726695AbfGJA2Z (ORCPT + 99 others); Tue, 9 Jul 2019 20:28:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:46204 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726133AbfGJA2Z (ORCPT ); Tue, 9 Jul 2019 20:28:25 -0400 Received: from localhost.localdomain (c-73-223-200-170.hsd1.ca.comcast.net [73.223.200.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0E7DC20645; Wed, 10 Jul 2019 00:28:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562718504; bh=pgC6c3DPV5AItfmGQQFtB/x1Xt0vg1j5Q5WBogBNnOY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bcORr81NEQsz5D+zOUG6k8DlarV4FeSW19kgXYYSMd9qxtzYAp2QLxXViDAJRru6M dtwMY3UTEic/u5ydDJe4uucQjbfejE/8h+7uvSrHfdzgxUJFHps8dEZGqI+bVmC1qW p6MjkxHTx75iefkEq1M0pWmNUiKj0HVfWBXbH/Ys= Date: Tue, 9 Jul 2019 17:28:23 -0700 From: Andrew Morton To: Ralph Campbell Cc: , , =?ISO-8859-1?Q?J?= =?ISO-8859-1?Q?=E9r=F4me?= Glisse , "Kirill A. Shutemov" , Mike Kravetz Subject: Re: [PATCH] mm/hmm: Fix bad subpage pointer in try_to_unmap_one Message-Id: <20190709172823.9413bb2333363f7e33a471a0@linux-foundation.org> In-Reply-To: <20190709223556.28908-1-rcampbell@nvidia.com> References: <20190709223556.28908-1-rcampbell@nvidia.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 9 Jul 2019 15:35:56 -0700 Ralph Campbell wrote: > When migrating a ZONE device private page from device memory to system > memory, the subpage pointer is initialized from a swap pte which computes > an invalid page pointer. A kernel panic results such as: > > BUG: unable to handle page fault for address: ffffea1fffffffc8 > > Initialize subpage correctly before calling page_remove_rmap(). I think this is Fixes: a5430dda8a3a1c ("mm/migrate: support un-addressable ZONE_DEVICE page in migration") Cc: stable yes?