Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2 2/3] ata: make qc_prep return an int
To:     Jiri Slaby <jslaby@suse.cz>
Cc:     linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
References: <20190709100203.19049-1-jslaby@suse.cz>
 <20190709100203.19049-2-jslaby@suse.cz>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <4ed428e5-8108-e6c5-b580-9dd20ec049f0@kernel.dk>
Date:   Tue, 9 Jul 2019 21:04:11 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <20190709100203.19049-2-jslaby@suse.cz>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 7/9/19 4:02 AM, Jiri Slaby wrote:
> In case a driver wants to return an error. sata_mv is one of those --
> see the next patch.

Not against the change as such, but there seems to be some confusion on
int vs enum ata_completion_errors. The latter is probably poorly named
if you're going to start using it for prep return, but would probably
still be saner to have an AC_ERR_OK as 0 and use that and use the enum.

-- 
Jens Axboe