Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Keyur Patel <iamkeyur96@gmail.com>
Cc:     iamkeyur96@gmail.com, Johan Hovold <johan@kernel.org>,
        linux-kernel@vger.kernel.org
Subject: [PATCH v2] gnss: core: added logging statement when kfifo_alloc fails
Date:   Tue,  9 Jul 2019 19:59:56 -0400
Message-Id: <20190709235957.2481-1-iamkeyur96@gmail.com>
In-Reply-To: <61c2ba4e229a6971e90627433bedae2dd28ea6a1.camel@perches.com>
References: <61c2ba4e229a6971e90627433bedae2dd28ea6a1.camel@perches.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
To:     unlisted-recipients:; (no To-header on input)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Added missing logging statement when kfifo_alloc fails, to improve
debugging.

Signed-off-by: Keyur Patel <iamkeyur96@gmail.com>
---
Changes in v2:
- fixed braces
---
 drivers/gnss/core.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gnss/core.c b/drivers/gnss/core.c
index e6f94501cb28..1b7387ee643b 100644
--- a/drivers/gnss/core.c
+++ b/drivers/gnss/core.c
@@ -255,8 +255,10 @@ struct gnss_device *gnss_allocate_device(struct device *parent)
 	init_waitqueue_head(&gdev->read_queue);
 
 	ret = kfifo_alloc(&gdev->read_fifo, GNSS_READ_FIFO_SIZE, GFP_KERNEL);
-	if (ret)
+	if (ret) {
+		pr_err("kfifo_alloc failed\n");
 		goto err_put_device;
+	}
 
 	gdev->write_buf = kzalloc(GNSS_WRITE_BUF_SIZE, GFP_KERNEL);
 	if (!gdev->write_buf)
-- 
2.22.0