Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp8728407ybi; Tue, 9 Jul 2019 22:07:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqySlMOe4MKXlhXCVBEOK2P5ehroZ9BK0ohmoYW8kksyD+nkyrb+5PE+Ago2iguTTEwGkvCt X-Received: by 2002:a17:90a:ca0f:: with SMTP id x15mr4427866pjt.82.1562735220987; Tue, 09 Jul 2019 22:07:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562735220; cv=none; d=google.com; s=arc-20160816; b=fwqOBXQC9yfejZVISXHdVqP9djWr/KWJ3YbGeB5/PcKO/cn/MDSj+wAiGgFb6lttOQ 4yT4an8t1u9bhCkLkOVMydfETIAbRTEuBldjsvSCfw+TBnP+SoRQF7ivVpRZiSsSSYdF Gijb9gA+oHAY0LzZ6J3OF4fnR1JkIaVxGw1A7UcC/dqDOotyEse/7HweosHvxJx6aRa8 HgiBiWKM+ONWyUMHux39m+tMVjD2e0qDBQ3WyNLvjR59tfHFKQqqhokDjXix84b0pQlz D1PpBpnFkDfY41M19LIOiQgt/O0IS+oEsNwWs4yn7ma0PB2OTRwZ1FkEsxA5ftGW36XX gE9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=OQl5tZ57f4IfZXOkiNKoS/9wDpZpCZVsdp1uolAJfYg=; b=oushWPJS64gbrJfQVmrgc5wsnDE82NRLLwb2ylvYS0TfkpmoPFpi0EJcEJM2hB/qzM mzglrk9DvmtrObxUrlyoEcTls8eRGZPKl3/uLhlbAANyzNWcKUWa17LW6/jar1AkyRgd qIWe8V8Iy8/vvErowlSRKPC6mii3Q+4b1EEg+INEPUCjowW+hADVftilBIbOtpgohbeS GEZ8fjN0Sevp2x6kp7BW2b4z02o4yqPpiAFdqY9AZNrlDMhIyejFTQ1Cr1heFRjnTy3o eymz9zmmdxHgkkVYTBaQhnShBLff+4Zu4tU2mSPtGknHxTvD8JGoRs2WacOfawzdWM8O 2lrw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m62si1138021pgm.392.2019.07.09.22.06.45; Tue, 09 Jul 2019 22:07:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726924AbfGJFE7 (ORCPT + 99 others); Wed, 10 Jul 2019 01:04:59 -0400 Received: from smtprelay0195.hostedemail.com ([216.40.44.195]:56954 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726392AbfGJFEv (ORCPT ); Wed, 10 Jul 2019 01:04:51 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id CB52F1803A16D; Wed, 10 Jul 2019 05:04:49 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::,RULES_HIT:41:355:379:541:800:960:973:982:988:989:1260:1345:1359:1437:1534:1541:1711:1730:1747:1777:1792:2194:2198:2199:2200:2393:2559:2562:3138:3139:3140:3141:3142:3352:3867:3870:4321:4605:5007:6261:8784:9121:10004:10848:11026:11233:11473:11657:11658:11914:12043:12048:12296:12297:12438:12555:12895:13069:13311:13357:14096:14181:14384:14394:14721:21080:21451:21627:30054,0,RBL:23.242.196.136:@perches.com:.lbl8.mailshell.net-62.8.0.180 64.201.201.201,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: coal43_ccb02173980f X-Filterd-Recvd-Size: 2914 Received: from joe-laptop.perches.com (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf06.hostedemail.com (Postfix) with ESMTPA; Wed, 10 Jul 2019 05:04:47 +0000 (UTC) From: Joe Perches To: Andrew Morton , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Maxime Ripard , Chen-Yu Tsai Cc: "David S. Miller" , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 08/12] net: stmmac: Fix misuses of GENMASK macro Date: Tue, 9 Jul 2019 22:04:21 -0700 Message-Id: X-Mailer: git-send-email 2.15.0 In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arguments are supposed to be ordered high then low. Signed-off-by: Joe Perches --- drivers/net/ethernet/stmicro/stmmac/descs.h | 2 +- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/descs.h b/drivers/net/ethernet/stmicro/stmmac/descs.h index 10429b05f932..9f0b9a9e63b3 100644 --- a/drivers/net/ethernet/stmicro/stmmac/descs.h +++ b/drivers/net/ethernet/stmicro/stmmac/descs.h @@ -123,7 +123,7 @@ #define ETDES1_BUFFER2_SIZE_SHIFT 16 /* Extended Receive descriptor definitions */ -#define ERDES4_IP_PAYLOAD_TYPE_MASK GENMASK(2, 6) +#define ERDES4_IP_PAYLOAD_TYPE_MASK GENMASK(6, 2) #define ERDES4_IP_HDR_ERR BIT(3) #define ERDES4_IP_PAYLOAD_ERR BIT(4) #define ERDES4_IP_CSUM_BYPASSED BIT(5) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c index 6d5cba4075eb..4c5db00c1d18 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c @@ -192,7 +192,7 @@ static const struct emac_variant emac_variant_h6 = { /* Used in RX_CTL1*/ #define EMAC_RX_MD BIT(1) -#define EMAC_RX_TH_MASK GENMASK(4, 5) +#define EMAC_RX_TH_MASK GENMASK(5, 4) #define EMAC_RX_TH_32 0 #define EMAC_RX_TH_64 (0x1 << 4) #define EMAC_RX_TH_96 (0x2 << 4) @@ -203,7 +203,7 @@ static const struct emac_variant emac_variant_h6 = { /* Used in TX_CTL1*/ #define EMAC_TX_MD BIT(1) #define EMAC_TX_NEXT_FRM BIT(2) -#define EMAC_TX_TH_MASK GENMASK(8, 10) +#define EMAC_TX_TH_MASK GENMASK(10, 8) #define EMAC_TX_TH_64 0 #define EMAC_TX_TH_128 (0x1 << 8) #define EMAC_TX_TH_192 (0x2 << 8) -- 2.15.0