Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp8861405ybi; Wed, 10 Jul 2019 00:35:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqwtCddZwGRwckgxfPi1MacYZT5yd26JbD5tZfB0rrNx00qK7/iUd1aezeeB04+YrL7HFDf7 X-Received: by 2002:a63:2a8d:: with SMTP id q135mr35337604pgq.46.1562744126950; Wed, 10 Jul 2019 00:35:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562744126; cv=none; d=google.com; s=arc-20160816; b=HczGxTH8AB9O393grJT6RF5pINeVmu+Y3lhhoNtNBHarpOEDkMYLq/JzouTD6lNgl+ oAvEir4Twl2Vq+xwH3vMtatR5fX4L/4vkjHvVgBKLJI14XoZlfxU44p0Of5ZHwNZPfzp 5Yxejdj+qY1EGB7wR4bDmtEPGRVU91UM7eUxjPV1rJHotrbserb7IyTaXs/MbU/ak4jv 8CNJz4EQh8XQ+/f3HH6cdxCetISRhk4kI34+0E6FCk7biASirRPE9s0pd1nTqQDTQurQ IuGCf4tFuhjfLZoR2rA6KQiZaGIpq7SPGUlqmNA+6PaNzSx3GCCbFgZGOnwsmZ1qiQHf A69A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=szufwnlf+uDBbFhg/Z9vUNzzyu+n2WE4EH+cV8xCTds=; b=bnfLkprm+xVurPR+g6iGGeeLd/993hNo3aDo2BYKYBiAzFOhpXke3qpynVRKde8UzN dnBPusZObClmAG9kSn2XbGGXWyXN/DKjdnlK6T7EdX+m2l0mcsNfLX8941wjQp0APUnb 0k2BgJnRZ7UCHj/WulJxdbCEaxRlzwdayq+O8qD2ItxVKYrbWvtkyuITHXveoYwgZBO5 7LPBM11VcEvKnc9a0b0HxcFKhIHJtd7FbY1WKAjTbwWIaBN/0/+EdNpfnKhJgixHYGGX u49kmW+I3haS4Re3HBAe4H71coJN68lvENwvnPPv51JTmzOwhq0XO1rHvLW8BOJq3r/k vmXg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a88si1525717pje.6.2019.07.10.00.35.10; Wed, 10 Jul 2019 00:35:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727247AbfGJHdw (ORCPT + 99 others); Wed, 10 Jul 2019 03:33:52 -0400 Received: from out1.zte.com.cn ([202.103.147.172]:36690 "EHLO mxct.zte.com.cn" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726203AbfGJHdv (ORCPT ); Wed, 10 Jul 2019 03:33:51 -0400 Received: from mse-fl2.zte.com.cn (unknown [10.30.14.239]) by Forcepoint Email with ESMTPS id 9744B65CB9B0520C0A0A; Wed, 10 Jul 2019 15:33:46 +0800 (CST) Received: from notes_smtp.zte.com.cn ([10.30.1.239]) by mse-fl2.zte.com.cn with ESMTP id x6A7Vu2q076458; Wed, 10 Jul 2019 15:31:56 +0800 (GMT-8) (envelope-from yang.bin18@zte.com.cn) Received: from fox-host8.localdomain ([10.74.120.8]) by szsmtp06.zte.com.cn (Lotus Domino Release 8.5.3FP6) with ESMTP id 2019071015321609-2237267 ; Wed, 10 Jul 2019 15:32:16 +0800 From: Yang Bin To: lduncan@suse.com Cc: cleech@redhat.com, jejb@linux.ibm.com, martin.petersen@oracle.com, open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, xue.zhihong@zte.com.cn, wang.yi59@zte.com.cn, wang.liang82@zte.com.cn, " Yang Bin " Subject: [PATCH] Check sk before sendpage Date: Wed, 10 Jul 2019 15:30:09 +0800 Message-Id: <1562743809-31133-1-git-send-email-yang.bin18@zte.com.cn> X-Mailer: git-send-email 1.8.3.1 X-MIMETrack: Itemize by SMTP Server on SZSMTP06/server/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2019-07-10 15:32:16, Serialize by Router on notes_smtp/zte_ltd(Release 9.0.1FP7|August 17, 2016) at 2019-07-10 15:31:59, Serialize complete at 2019-07-10 15:31:59 X-MAIL: mse-fl2.zte.com.cn x6A7Vu2q076458 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: " Yang Bin " Before xmit,iscsi may disconnect just now. So must check connection sock NULL or not,or kernel will crash for accessing NULL pointer. Signed-off-by: Yang Bin --- drivers/scsi/iscsi_tcp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c index 7bedbe8..a59c49f 100644 --- a/drivers/scsi/iscsi_tcp.c +++ b/drivers/scsi/iscsi_tcp.c @@ -264,6 +264,9 @@ static int iscsi_sw_tcp_xmit_segment(struct iscsi_tcp_conn *tcp_conn, unsigned int copied = 0; int r = 0; + if (!sk) + return -ENOTCONN; + while (!iscsi_tcp_segment_done(tcp_conn, segment, 0, r)) { struct scatterlist *sg; unsigned int offset, copy; -- 1.8.3.1