Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp8966234ybi; Wed, 10 Jul 2019 02:27:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqx0Xv8irZ3pB/vEs+VAgk8fXWhmOxoAt2b641SBLMNRDYT39QvxcpplUeeHl9hsDGGKi365 X-Received: by 2002:a63:e70f:: with SMTP id b15mr1414489pgi.152.1562750865051; Wed, 10 Jul 2019 02:27:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562750865; cv=none; d=google.com; s=arc-20160816; b=XJ085bpsGr+lpjhyP4LsdVpt1XdApfM785wcxhjx1lHPeO1LyfqvqxNKJb2q756wCa OjsBb96yYOFwKRBLOh6K7L5IhaCWWA5A5qYGT6Z85Q6LfA5OBmCPKgCo0KM0RP9u5Lee +SA32vs3dv4eIabnsW1FzPGTjKiwsGCAFmI5J51G5J+RoYxxgS92MeDMjHbtmID2Dp2i BrcNMbT+5vUOPMgFY3/Sdh1iqgnzAx6wWhkCRSYqKX7J3rLygAypLN6MkMzocEleiRZ2 1zE32bREm14CkWmLjse1rRgejW8h90wA1KxMmZi0msKC1g0YkoXjmvblw03n4nfYO3y/ FagQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=JRqIl2KAaMQ78hZJopjkx5v558dsW2jWgaNwGOkG2XU=; b=sP31sZBO+frKl+QO2/4JiBQuAz6pHIs24AH+p4TvAtJ7voGIOpfIf/3OcgEMyfBLz0 9UVJ+n9bOIg54ndHtr9s+cKKESms35rmtiZBOaDdHvzffsDpk1bPyyW6u8Z5ICdTKIwS Uy2Rxd/AklW0UvttQedAi6x+X9nyHKfwWZ7sjCgj5tJmflxwXiqKO4AT6vdYEqwj5xVv R1f/PK5XynLaDTFqGzr0w2jk3gH82T9ucxBrjD71py2sIaCLPNgOUQl6qzM2XwVSsEYG LEhQo41jyegItZWxz5WA/rVBTVm+hfBqwKQb8g983Q0k3zUIq2esCkvmHfqXqHVhssVK HTxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=P23TBw34; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bc10si1609872plb.43.2019.07.10.02.27.29; Wed, 10 Jul 2019 02:27:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=P23TBw34; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727064AbfGJIAc (ORCPT + 99 others); Wed, 10 Jul 2019 04:00:32 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:43628 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725956AbfGJIAc (ORCPT ); Wed, 10 Jul 2019 04:00:32 -0400 Received: by mail-wr1-f67.google.com with SMTP id p13so1331653wru.10; Wed, 10 Jul 2019 01:00:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=JRqIl2KAaMQ78hZJopjkx5v558dsW2jWgaNwGOkG2XU=; b=P23TBw34QRXOzC2Juom2uCxE044GBwY41H8Cux1QOKPlVlemX35xfsiQvhYhvbksck RUoz6d6JgsGUF9q/yjqy9KmgAGItQa/VNqTGAQON76GrHbx2pU3r2TJmyvi6VOYyA8OY 5G1+arOCEDb5zIaNMPiYTkcN//Npe2ugxm3Z1/tmam++5Q6cTQbwAoE408tdDsFtug2v ntVodpblTbR+3FpnaKo3r1Cuodm4D/yKAYxyv/C06+sxYGdTJoPKmbaAbROpxqFjYzRd mhClyczrep/M0wQwoMnu44NTFMDFJpoY9bWf66iGVTi5I1MIkr8n3Jw2gsi1SB96nytN H62w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JRqIl2KAaMQ78hZJopjkx5v558dsW2jWgaNwGOkG2XU=; b=EIuYob7rXeg5WIkkKqewQpxEvUWxmS5YMSZNjHxuiogCqo6yZvXzhM0N4bH7aGxpRb 0rV2tWqcKB9LBvhykIU77MRE1DvOK+yznuEhmTgtitFiI86LSx7trSafhFDek2wLHcyB 4UKewrZiOTPiIFGCh8eWd4E4ZKLHtW9W3NHI57ndxuOzGuYVM46fTg5RPiTbQp7YqGlI /UQLX4PridgH8LTG6dCNNLWKkfzYgomcenP7IJMjjhRsLKuBrKNM5Mv3duXwtayG9AvO cG+eCSwk3vTO/JA6ZzgF3rXtPqzRyenYX2X/SE8jlIN1F2SH0CqjE8VLwEinuKA01E+x CbXA== X-Gm-Message-State: APjAAAXZAeVsagGGQ0Lyt2LHSonbjG/jw1x9Ta/qwLCB3i1+MXXWcW90 3PF87q4owwe4H8oE1ty4yTtCMgXG X-Received: by 2002:a05:6000:1043:: with SMTP id c3mr19970707wrx.236.1562745629922; Wed, 10 Jul 2019 01:00:29 -0700 (PDT) Received: from [192.168.8.147] (31.172.185.81.rev.sfr.net. [81.185.172.31]) by smtp.gmail.com with ESMTPSA id q16sm2714542wra.36.2019.07.10.01.00.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Jul 2019 01:00:29 -0700 (PDT) Subject: Re: [PATCH] tipc: ensure skb->lock is initialised To: Jon Maloy , Eric Dumazet , Chris Packham , "ying.xue@windriver.com" , "davem@davemloft.net" Cc: "netdev@vger.kernel.org" , "tipc-discussion@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" References: <20190707225328.15852-1-chris.packham@alliedtelesis.co.nz> <2298b9eb-100f-6130-60c4-0e5e2c7b84d1@gmail.com> <361940337b0d4833a5634ddd1e1896a9@svr-chch-ex1.atlnz.lc> <87fd2150548041219fc42bce80b63c9c@svr-chch-ex1.atlnz.lc> From: Eric Dumazet Message-ID: Date: Wed, 10 Jul 2019 10:00:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/9/19 10:15 PM, Jon Maloy wrote: > > It is not only for lockdep purposes, -it is essential. But please provide details about where you see that more fixes are needed. > Simple fact that you detect a problem only when skb_queue_purge() is called should talk by itself. As I stated, there are many places where the list is manipulated _without_ its spinlock being held. You want consistency, then - grab the spinlock all the time. - Or do not ever use it. Do not initialize the spinlock just in case a path will use skb_queue_purge() (instead of using __skb_queue_purge())