Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp9006023ybi; Wed, 10 Jul 2019 03:08:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqzkeaZZ/+YWBtkU4cuGMv2PGyyf2Opek1iqaI2htbwnLE/jdHTi1sNbGO2CMMHgibhGIxyh X-Received: by 2002:a63:f312:: with SMTP id l18mr33500780pgh.440.1562753297567; Wed, 10 Jul 2019 03:08:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562753297; cv=none; d=google.com; s=arc-20160816; b=v93D24lAmrmJbOF+rFsRFtRnfpBcseYaoElsmr4fmlBu7s0u3nsRVVOY8J5MeiAeq/ D3HhtXP7O7Ksc+Fhr7PVmqoQEO6Sv+5mQ5fou8mv9J4ugRaJ1h5BqhFc2F+91eoZFnNM 0kqZRrip5MuX6sL8R8LbLTAZBlz2I2m235HjLA9hfHXCAb0XTOoRXOhqb+6yVPDJoXsv /lJVvhCWwClKkZMXwY+w3OHe7sxFPx5c9kXWYBDT/fYfOAB5wOj6GRZeNptUJPoFtvMq XIO1ydGBizPWbQd+m0DYVgAfyzTmtWhuSo/zVJaCklY3/5ykqtK/Ebjx5Rn7Yh1uiOXz IqDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:subject:cc:to:from:message-id:date; bh=Fn4QCDeaxlD4ZTfimE+NiuI9jxRGQiFXlAfGNkbCII8=; b=symMNTI9/EBgETDgT2zMkQu4fNlv1zMvwltFjnY6bImhptkD6NB1tDsDaG+6zXaBdp zVwaK7m8cppNbc23pTQksvsMrtBoo1h1Xnvsnr1jog4Yrja97pbWA3AXM7Wjej17LvAh KjtLpI2cQhcg3X9ow2gQYFYzGRhf0UL+Zjj2mB4czsAXzPXWDzDkdzHNILLuE82kMyf8 IIWGejUof7byv5N4IlFCbr1R4y0/jy7Bcs1M2fKupStlsrvpCi3d0elUyaerq/DKvtM6 hTDm5RCi3vpNYArwXNrefeiC3g7qyRPR+umJ+J5hDkeoQZRmsT1yAVSl3Bd7QvC0Oqye IIHQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v22si1879070pfe.275.2019.07.10.03.07.55; Wed, 10 Jul 2019 03:08:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727348AbfGJJtd (ORCPT + 99 others); Wed, 10 Jul 2019 05:49:33 -0400 Received: from mx2.suse.de ([195.135.220.15]:55496 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725994AbfGJJtd (ORCPT ); Wed, 10 Jul 2019 05:49:33 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 1D4E5B090; Wed, 10 Jul 2019 09:49:32 +0000 (UTC) Date: Wed, 10 Jul 2019 11:49:31 +0200 Message-ID: From: Takashi Iwai To: "Hariprasad Kelam" Cc: , "Thomas Gleixner" , "Kate Stewart" , "Allison Randal" , "Jaroslav Kysela" , "Takashi Iwai" , Subject: Re: [PATCH] sound: pci: lx6464es: Remove unneeded variable err In-Reply-To: <20190710023059.GA14204@hari-Inspiron-1545> References: <20190710023059.GA14204@hari-Inspiron-1545> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 10 Jul 2019 04:30:59 +0200, Hariprasad Kelam wrote: > > This patch fixes below issue reported by coccicheck > sound/pci/lx6464es/lx6464es.c:256:5-8: Unneeded variable: "err". Return > "0" on line 258 > > We cannot change return value as its registered with snd_pcm_ops->close > > Signed-off-by: Hariprasad Kelam Applied, thanks. Takashi