Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 10 Jul 2019 11:56:25 +0200
Message-ID: <s5hftnerz5i.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     "Hariprasad Kelam" <hariprasad.kelam@gmail.com>
Cc:     <alsa-devel@alsa-project.org>,
        "Michael Ellerman" <mpe@ellerman.id.au>,
        "Geoff Levand" <geoff@infradead.org>,
        "Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
        <linuxppc-dev@lists.ozlabs.org>,
        "Jaroslav Kysela" <perex@perex.cz>,
        "Paul Mackerras" <paulus@samba.org>,
        "Takashi Iwai" <tiwai@suse.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sound: ppc: snd_ps3: Remove Unneeded variable: "ret"
In-Reply-To: <20190710023946.GA15604@hari-Inspiron-1545>
References: <20190710023946.GA15604@hari-Inspiron-1545>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 10 Jul 2019 04:39:46 +0200,
Hariprasad Kelam wrote:
> 
> This patch fixes below issue reported by coccicheck
> sound/ppc/snd_ps3.c:631:5-8: Unneeded variable: "ret". Return "0" on
> line 668
> 
> We cannot change return type of snd_ps3_pcm_trigger as it is registered
> with snd_pcm_ops->trigger
> 
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>

Applied (with the correction of the description again).


thanks,

Takashi