Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp9171426ybi; Wed, 10 Jul 2019 05:56:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqxGZlasf/1Dpo4DWPma6m6aTX1d6mKjINDbpCiVzH2xQyJj+U0Ur2mM+QTESgdjtAsXA6Vh X-Received: by 2002:a63:f1c:: with SMTP id e28mr36705433pgl.147.1562763377694; Wed, 10 Jul 2019 05:56:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562763377; cv=none; d=google.com; s=arc-20160816; b=QepN4sLKhwBRPmNHt9MW0T98LFltQaJsfRBjP1Yyl6cN4yFmnMEtA1y8ZnCYrrKom9 +PkditvJZ7iaqXza4jkbHmtziRXdnCdy9xJrkvO0U3/jQiUWGWTc9+1SPCxp8mgBC/Xc WUKBfLrgxQHFedvTDjOoM6WUs2jUGxZteQ4KOcqdrVl9ZsFLb/SoXpWr92XyRJ0vUtlY UamBks8Lt9KGM1yn1xMeBu8jaq5kbbo2wnIBdB42tdHSh3lWABpfiD8ogawA0LOKuhyX YWxTordHSOIdGDPN45bRd+gEByhvU8kUB/VIyAppYvYOP4mxbaBQBU1XzbkIaf+/xQTI VuwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=NT32iiNsUZosTkYAuyAzrO89s1d3Gh6psXZwmMpRTgQ=; b=reO5QmYW+XWwj8JquR56bB+LTszF6k4dIZSjV/YkU0+sgxBU3pBxKwUe4j1w5R4CRT LcQCsm8/7mEIKFjtgvoJUFmJzE8OZWaoDVcl/e2bhxgPj4nDTt+8EexB8AY48bJx8+DE uxsTALhdeTGoF132w1o+J3xUPAGmVFB5wfF8E7snB3xhNdLZQExn+nD1yObwZvgoFwLJ qTd+Eziwc5DkhBR8rn7SNdqQfxW4zu42/kLdySR0i1rl41krCIBb5K0y5bbHt6f8aKoF 0pWtEGnUNpnzniLGZ1Z0qlNvJh85Wbz41WbGrZ11H76CIURExA3DAexcX8NVNWQcjQt1 ovMQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r199si2117544pfr.233.2019.07.10.05.56.01; Wed, 10 Jul 2019 05:56:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726333AbfGJMgn (ORCPT + 99 others); Wed, 10 Jul 2019 08:36:43 -0400 Received: from mga09.intel.com ([134.134.136.24]:22835 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725911AbfGJMgm (ORCPT ); Wed, 10 Jul 2019 08:36:42 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jul 2019 05:36:42 -0700 X-IronPort-AV: E=Sophos;i="5.63,474,1557212400"; d="scan'208";a="170906898" Received: from jkrzyszt-desk.igk.intel.com ([172.22.244.18]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jul 2019 05:36:39 -0700 From: Janusz Krzysztofik To: Chris Wilson Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter , =?UTF-8?q?Micha=C5=82=20Wajdeczko?= , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Janusz Krzysztofik Subject: [RFC PATCH 0/6] Rename functions to match their entry points Date: Wed, 10 Jul 2019 14:36:25 +0200 Message-Id: <20190710123631.26575-1-janusz.krzysztofik@linux.intel.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Need for this was identified while working on split of driver unbind path into _remove() and _release() parts. Consistency in function naming has been recognized as helpful when trying to work out which phase the code is in. What I'm still not sure about is desired depth of that modification - how deep should we go down with renaming to not override meaningfull function names. Please advise if you think still more deep renaming makes sense. Thanks, Janusz Janusz Krzysztofik (6): drm/i915: Rename "_load"/"_unload" to match PCI entry points drm/i915: Replace "_load" with "_probe" consequently drm/i915: Propagate "_release" function name suffix down drm/i915: Propagate "_remove" function name suffix down drm/i915: Propagate "_probe" function name suffix down drm/i915: Rename "inject_load_failure" module parameter drivers/gpu/drm/i915/display/intel_bios.c | 4 +- drivers/gpu/drm/i915/display/intel_bios.h | 2 +- .../gpu/drm/i915/display/intel_connector.c | 2 +- drivers/gpu/drm/i915/display/intel_display.c | 2 +- .../drm/i915/display/intel_display_power.c | 6 +- .../drm/i915/display/intel_display_power.h | 2 +- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +- drivers/gpu/drm/i915/i915_drv.c | 111 +++++++++--------- drivers/gpu/drm/i915/i915_drv.h | 20 ++-- drivers/gpu/drm/i915/i915_gem.c | 12 +- drivers/gpu/drm/i915/i915_gem_gtt.c | 4 +- drivers/gpu/drm/i915/i915_gem_gtt.h | 2 +- drivers/gpu/drm/i915/i915_params.c | 2 +- drivers/gpu/drm/i915/i915_params.h | 2 +- drivers/gpu/drm/i915/i915_pci.c | 6 +- drivers/gpu/drm/i915/intel_gvt.c | 7 +- drivers/gpu/drm/i915/intel_gvt.h | 4 +- drivers/gpu/drm/i915/intel_runtime_pm.c | 2 +- drivers/gpu/drm/i915/intel_runtime_pm.h | 2 +- drivers/gpu/drm/i915/intel_uncore.c | 2 +- drivers/gpu/drm/i915/intel_wopcm.c | 2 +- 21 files changed, 100 insertions(+), 98 deletions(-) -- 2.21.0