Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp9174328ybi; Wed, 10 Jul 2019 05:59:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqzVzNyOePLOyIVqSspIjYbeg9AHJtsgIA+wluEwR0GkNtxqYBc8Ecl+HRq1080P315WgJeH X-Received: by 2002:a63:dc50:: with SMTP id f16mr37443898pgj.447.1562763575102; Wed, 10 Jul 2019 05:59:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562763575; cv=none; d=google.com; s=arc-20160816; b=CaQ98PG5a+3euXPRT/mP3v5voYPkqmbMU7kP25YqfvRS8WjKVigo+142NFnY2rkl1P uIZ4Jd5q4dsE/sYPo4BJpwOcpBEbGhbdIsYPQIh3W62H/q2HYehmF7Uha+98mAKPRU5d /Du+wz81u4PwO48euw5GhqBH6zmJoZUDJvY8zQejG+DVHOdsPf5FvTSZxMMX1mN/GiTx 9j8GeM9ifRsx8Q3Z1AlZItU03WeXT+tq4qi2roQ9eL9cMIl2ePLe61/Ljn36M4Z9HwmA lNW1avc1RYMNgnQ2HlvENVkjNFFzg5NBWtqnHz+Icv89k8XNfaXf4LBujryMF+vC+M40 zgUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=qg7q/rPQhK+x8FwCFh8/lIkH4T2w8Mb1NhPuuoe3Nwk=; b=FL1iYzUE3RWWgcLruvokgr4a+KuBHlqmKuESqx2/Fh2vnZFyTbRZaghhbjE0Ud+wdP SZyo3vGXLRlCj92xEaJa2V+7xZwj8GixS9OPXPK+4NYfssNm9P418XGLhZAqeHLBBrs0 PPX1WYjbtHAYJo3daH+m+UctLx49RuLf/oLvObFQdqUCfH/JanHrhWRr12OFdQYWzkik 72RVoZM315dCbgBZg4BIq1bpdz11vhx6HsQEbKmX22sLBXz7BWBdtwT19m09aDnEKClL XDVu5yyj07s//dTaPnGmSTIAjpCpIJgELFhxw95GciqzDcQbGnNto5qNra65XIgvo1cY AzLg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r199si2117544pfr.233.2019.07.10.05.59.19; Wed, 10 Jul 2019 05:59:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727400AbfGJMhB (ORCPT + 99 others); Wed, 10 Jul 2019 08:37:01 -0400 Received: from mga09.intel.com ([134.134.136.24]:22835 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727376AbfGJMhA (ORCPT ); Wed, 10 Jul 2019 08:37:00 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jul 2019 05:36:59 -0700 X-IronPort-AV: E=Sophos;i="5.63,474,1557212400"; d="scan'208";a="170906953" Received: from jkrzyszt-desk.igk.intel.com ([172.22.244.18]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jul 2019 05:36:57 -0700 From: Janusz Krzysztofik To: Chris Wilson Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter , =?UTF-8?q?Micha=C5=82=20Wajdeczko?= , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Janusz Krzysztofik Subject: [RFC PATCH 6/6] drm/i915: Rename "inject_load_failure" module parameter Date: Wed, 10 Jul 2019 14:36:31 +0200 Message-Id: <20190710123631.26575-7-janusz.krzysztofik@linux.intel.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190710123631.26575-1-janusz.krzysztofik@linux.intel.com> References: <20190710123631.26575-1-janusz.krzysztofik@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use the "probe" nomenclature for consistency with internally used names of functions and variables. Requires adjustment of IGT tests and possibly affects other user custom applications. Signed-off-by: Janusz Krzysztofik --- drivers/gpu/drm/i915/i915_drv.c | 10 +++++----- drivers/gpu/drm/i915/i915_params.c | 2 +- drivers/gpu/drm/i915/i915_params.h | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index 7241a7d14e9b..3bac6be9f37d 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++ b/drivers/gpu/drm/i915/i915_drv.c @@ -85,13 +85,13 @@ static unsigned int i915_probe_fail_count; bool __i915_inject_probe_failure(const char *func, int line) { - if (i915_probe_fail_count >= i915_modparams.inject_load_failure) + if (i915_probe_fail_count >= i915_modparams.inject_probe_failure) return false; - if (++i915_probe_fail_count == i915_modparams.inject_load_failure) { + if (++i915_probe_fail_count == i915_modparams.inject_probe_failure) { DRM_INFO("Injecting failure at checkpoint %u [%s:%d]\n", - i915_modparams.inject_load_failure, func, line); - i915_modparams.inject_load_failure = 0; + i915_modparams.inject_probe_failure, func, line); + i915_modparams.inject_probe_failure = 0; return true; } @@ -100,7 +100,7 @@ bool __i915_inject_probe_failure(const char *func, int line) bool i915_error_injected(void) { - return i915_probe_fail_count && !i915_modparams.inject_load_failure; + return i915_probe_fail_count && !i915_modparams.inject_probe_failure; } #endif diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c index 296452f9efe4..59a6586dae15 100644 --- a/drivers/gpu/drm/i915/i915_params.c +++ b/drivers/gpu/drm/i915/i915_params.c @@ -165,7 +165,7 @@ i915_param_named_unsafe(enable_dp_mst, bool, 0600, "Enable multi-stream transport (MST) for new DisplayPort sinks. (default: true)"); #if IS_ENABLED(CONFIG_DRM_I915_DEBUG) -i915_param_named_unsafe(inject_load_failure, uint, 0400, +i915_param_named_unsafe(inject_probe_failure, uint, 0400, "Force an error after a number of failure check points (0:disabled (default), N:force failure at the Nth failure check point)"); #endif diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index d29ade3b7de6..8c887413fc70 100644 --- a/drivers/gpu/drm/i915/i915_params.h +++ b/drivers/gpu/drm/i915/i915_params.h @@ -62,7 +62,7 @@ struct drm_printer; param(int, mmio_debug, -IS_ENABLED(CONFIG_DRM_I915_DEBUG_MMIO)) \ param(int, edp_vswing, 0) \ param(int, reset, 2) \ - param(unsigned int, inject_load_failure, 0) \ + param(unsigned int, inject_probe_failure, 0) \ param(int, fastboot, -1) \ param(int, enable_dpcd_backlight, 0) \ param(char *, force_probe, CONFIG_DRM_I915_FORCE_PROBE) \ -- 2.21.0