Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 10 Jul 2019 16:15:00 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Alex Shi <alex.shi@linux.alibaba.com>
Cc:     Ingo Molnar <mingo@redhat.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Wanpeng Li <wanpeng.li@hotmail.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] cputime: remove duplicate code in
 account_process_tick
Message-ID: <20190710141500.GQ3402@hirez.programming.kicks-ass.net>
References: <20190709060100.214154-1-alex.shi@linux.alibaba.com>
 <20190709060100.214154-2-alex.shi@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190709060100.214154-2-alex.shi@linux.alibaba.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jul 09, 2019 at 02:01:00PM +0800, Alex Shi wrote:
> In funcation account_process_tick, func actually do same things with
> irqtime_account_process_tick, whenever if IRQ_TIME_ACCOUNTING set or
> if sched_clock_irqtime enabled.
> 
> So it's better to reuse one function for both.

But it's not the exact same.. and you didn't say, not did you say why
that is fine.