Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp9430777ybi; Wed, 10 Jul 2019 10:07:32 -0700 (PDT) X-Google-Smtp-Source: APXvYqwftIfiAm9LPppFyGuQEW/x9UpXP01rDovyWvx37sAQY3awOc7Ui0UqFHHOgoFBGTVeyZPH X-Received: by 2002:a17:90a:7787:: with SMTP id v7mr8066442pjk.143.1562778452103; Wed, 10 Jul 2019 10:07:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562778452; cv=none; d=google.com; s=arc-20160816; b=j3Awn09U+Kr2/isbiGZyfWJSRFCh8CyG+YX9O6RnXUJU1UFQasMesJHiWoLzhY/M+m I7qMiHqaebuMerzp1IpJvxNqjkPEZ39Se4oKe2NBSiqqiTY6jesajQRWLdyBLlDlOkP7 le7Oqz2Lqy8IoYGQmhCuDuKoR1S3EY2bVoM8/CO6iCx7qcsXpT/FTrguGNRpMw3XAJdV S6FeFcBsQvaVjY0j24yXkR/gqhDaQZIw7eU6doIGvROL+HVJA/PJYa50VBYl4YL+B4Hr 20UzhFiSzGAcm2p5bL7zDCvgyv6+ToHwe2CMr0LbcALo7F8JCKKIv0nF4Ov3jUi/9Y53 Tb5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=54e4QrdXGFCGBxd7VLf2W9wi3fwbWVP+1qdwyWkA9ZU=; b=scBWdbXRQM1WPYxWrReTRlHpSakK7xkre9n1dlwCrxxLoDRhel4WjxK9uzCBffQdhD iLoMrUzH7Zjv2fCvPBH6OmFdmKGHbW3ju7DLbmEwgV0ZlDali5jCCOj3gW5/YQWgQr7g IfI+qqieyJB8mOmzH5vDjfUVkM83HEG8bCmgRbpRNxnKUt/cetT6VxI59JkEg6Il4Qi6 HwdIvTvDsqa5mU7uHUqQ3rOSwKGlzBmyjYKc/ecGSIuhFgYlIUCicjjgHIUxTox7Za/H zfE2yK3OGVe7KGoDs45JQCuDF8o+rd1i89ersaHfKXWEf4rs0RWCfWheqH0fzqdIRO6S Xjkw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s36si2528628pld.164.2019.07.10.10.07.10; Wed, 10 Jul 2019 10:07:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727940AbfGJQi5 (ORCPT + 99 others); Wed, 10 Jul 2019 12:38:57 -0400 Received: from verein.lst.de ([213.95.11.211]:51855 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726957AbfGJQi4 (ORCPT ); Wed, 10 Jul 2019 12:38:56 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 4BD2F227A81; Wed, 10 Jul 2019 18:38:53 +0200 (CEST) Date: Wed, 10 Jul 2019 18:38:53 +0200 From: Christoph Hellwig To: Marta Rybczynska Cc: Christoph Hellwig , Max Gurtovoy , kbusch , axboe , Sagi Grimberg , linux-nvme , linux-kernel , Samuel Jones , Jean-Baptiste Riaux Subject: Re: [PATCH v2] nvme: fix multipath crash when ANA desactivated Message-ID: <20190710163853.GB25486@lst.de> References: <1575872828.30576006.1562335512322.JavaMail.zimbra@kalray.eu> <989987da-6711-0abc-785c-6574b3bb768c@mellanox.com> <20190709212904.GB9636@lst.de> <516302383.30860772.1562736406606.JavaMail.zimbra@kalray.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <516302383.30860772.1562736406606.JavaMail.zimbra@kalray.eu> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 10, 2019 at 07:26:46AM +0200, Marta Rybczynska wrote: > Christoph, why would you like to put the use_ana function in the header? > It isn't used anywhere else outside of that file. nvme_ctrl_use_ana has a single caller in core.c as well.