Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp9501644ybi; Wed, 10 Jul 2019 11:24:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqwRlIHPYv17HZQCvY5ah+CWXSMywRxb+m/2TPmuQOEPirScj+bNeNFV3UjaVzmIQ7TZFTFv X-Received: by 2002:a63:c10d:: with SMTP id w13mr38096233pgf.28.1562783061325; Wed, 10 Jul 2019 11:24:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562783061; cv=none; d=google.com; s=arc-20160816; b=XS3eUH2DIKJ2wbv9UtI2u5ROwCM+69j4OVEFs9Erd/iFOY4YGCGbULwzlP5JZrgcog OAunVA9R7gws5xbJM20N4P4hbk6qu/ZZ3iWi0XVc5ueoAcL09vQ0m1DctNJKsDmEHTTg 5Zjl5biZ9N7yxGgRxFNth10QNoaRMeooc88xotn/ScoV8WaRQxcZyvHBLH31gmZa7fRx S/TltlrsHheHxddhOrnYxT6woCjUGVad3oG4fDA3MEUoWf+SH/p1YkctweM1y5smtObB GbqBAbqlYyRtCbZFDaAHjg+5qHWNQ7O1a2BVPEXTmWMiCJYA7xXyCkQ2L4lUXqXblk6r oOrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=iWMY9Ra6fhg6EXLcSiaO3PQbn2oiv74r4PYLZuZM2BU=; b=jmBr8AQQ39SkjpMawqDvcnkPPajcI3SB2uJCx4KliOXZFNWR9Nebnwv0hfe3lN3mU2 6HH6LgZL6F79tXF44m74jcdUoFDPnqLOqSUfvKx3DLXW4IAHn6n5EX/ojrCPncFQLaDB WAUe1LCpiK9wfQK1aCFBe9TS1OVgRHhz20H7cNY+PnncY+pWPqwhFce6ToHepRb7oDAN jDlgMl9kqA7ilZmf/EaKo8M5xv1MAl9fxB5Ji3eKFYuxEx9FIA3/WehJaaMh/jjCNpnt jyI3jHLBX1xpx4tt00UUEJ3x2Mzb9RkkjipAtjVJuXrlwhJ17bjO9VhheCpONr3/Q+05 NNgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=axQtLVlx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j70si2862670pgd.500.2019.07.10.11.24.04; Wed, 10 Jul 2019 11:24:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=axQtLVlx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728045AbfGJRoY (ORCPT + 99 others); Wed, 10 Jul 2019 13:44:24 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:46414 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727416AbfGJRoY (ORCPT ); Wed, 10 Jul 2019 13:44:24 -0400 Received: by mail-pf1-f196.google.com with SMTP id c73so1412871pfb.13 for ; Wed, 10 Jul 2019 10:44:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=iWMY9Ra6fhg6EXLcSiaO3PQbn2oiv74r4PYLZuZM2BU=; b=axQtLVlxBbG2rukB4uIEh3aDgpy4FVcpO0GP/piahI3Obgr+rZibgLCVElkJiFLY7w 3JeU1pgGcUvAjJcRn1s0c75htzs2+FGj/9N0jRvMyrTOIrRKuoNx+MB+l7IkG8G+s71L 89cqtxOCVpM5EfPFLvBjibAvHWJvgCpc2nVLRUGbBX0UKtG1lxR7l/ToMmPkdPDSn7So fZ9asLA/swzK89Ng61WiyMSN19TnEfEsP0wWxWd6vVTYQ59wz7HTFto7++v2UlC/wnZt XCH/XEdhlxPfFZJ0WwkBRJ1tgzdA8vKk19ExiwlatWdYZVOo1JH5BsmesMvm1aWejERz pSig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=iWMY9Ra6fhg6EXLcSiaO3PQbn2oiv74r4PYLZuZM2BU=; b=rcYFSv9B8N6nQVyKPveEjXmmc0QiBmUSWYNEf+bIVSuSef51E0dIMpISOp0g4OLBkH j5ke6Vdcmf1T3des4Xp+r5PJi/ZUOoXnzBODOEfj/7rKCszJ0YcSxnzkMgdP7Rmff0Xe BH42+R5kBt6ELEwiCS5wMD4u0Dn1WsTX+PKA660nKCEQw262ge8A6WBaOQnpDcJS7Fn9 RZgfXM8OOyPl5juZaDVnkXYHWSXMCDNFqmtUl+JdFyj6Zo62jjKnPD2AWyvcMS3T1sY7 B2pDiWmaAuuZ/VdoeXylUh/guoUZWNsgJUhm+Z2AgDj9h922ZW5qmsTaRzP4aG9n4ZRK sYgw== X-Gm-Message-State: APjAAAXpxvZhhGJ3AuBOLt6pl0Hp5RY2BB/80JIS3No/pe/mhDSqyMIG PM1dO7aJOvJ4Narsd42u4KyL4Q== X-Received: by 2002:a63:2606:: with SMTP id m6mr38342826pgm.436.1562780663359; Wed, 10 Jul 2019 10:44:23 -0700 (PDT) Received: from localhost ([2620:10d:c091:500::2:5b9d]) by smtp.gmail.com with ESMTPSA id l189sm2874023pfl.7.2019.07.10.10.44.21 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 10 Jul 2019 10:44:22 -0700 (PDT) Date: Wed, 10 Jul 2019 13:44:18 -0400 From: Johannes Weiner To: Song Liu Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, matthew.wilcox@oracle.com, kirill.shutemov@linux.intel.com, kernel-team@fb.com, william.kucharski@oracle.com, akpm@linux-foundation.org, hdanton@sina.com Subject: Re: [PATCH v9 1/6] filemap: check compound_head(page)->mapping in filemap_fault() Message-ID: <20190710174418.GA11197@cmpxchg.org> References: <20190625001246.685563-1-songliubraving@fb.com> <20190625001246.685563-2-songliubraving@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190625001246.685563-2-songliubraving@fb.com> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 24, 2019 at 05:12:41PM -0700, Song Liu wrote: > Currently, filemap_fault() avoids trace condition with truncate by -t > checking page->mapping == mapping. This does not work for compound > pages. This patch let it check compound_head(page)->mapping instead. > > Acked-by: Rik van Riel > Signed-off-by: Song Liu Acked-by: Johannes Weiner