Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190705101800.44561-1-biwen.li@nxp.com> <20190705101800.44561-2-biwen.li@nxp.com>
In-Reply-To: <20190705101800.44561-2-biwen.li@nxp.com>
From:   Li Yang <leoyang.li@nxp.com>
Date:   Wed, 10 Jul 2019 14:43:24 -0500
Message-ID: <CADRPPNTg52BNx6bN1P9+WQnf+gG8p2hnLuxWEUXoy1CSt55Npw@mail.gmail.com>
Subject: Re: [PATCH 2/2] Documentation: dt: binding: rtc: add binding for ftm
 alarm driver
To:     Biwen Li <biwen.li@nxp.com>, Rob Herring <robh+dt@kernel.org>
Cc:     a.zummo@towertech.it, alexandre.belloni@bootlin.com,
        linux-rtc@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
        Xiaobo Xie <xiaobo.xie@nxp.com>,
        Jiafei Pan <jiafei.pan@nxp.com>, Ran Wang <ran.wang_1@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jul 5, 2019 at 6:26 AM Biwen Li <biwen.li@nxp.com> wrote:
>
> The patch adds binding for ftm alarm driver
>
> Signed-off-by: Biwen Li <biwen.li@nxp.com>

Please add dts maintainer for binding patches.  I have added Rob.

> ---
>  .../devicetree/bindings/rtc/rtc-fsl-ftm-alarm.txt  | 33 ++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/rtc/rtc-fsl-ftm-alarm.txt
>
> diff --git a/Documentation/devicetree/bindings/rtc/rtc-fsl-ftm-alarm.txt b/Documentation/devicetree/bindings/rtc/rtc-fsl-ftm-alarm.txt
> new file mode 100644
> index 0000000..0f330b4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/rtc-fsl-ftm-alarm.txt
> @@ -0,0 +1,33 @@
> +Freescale FlexTimer Module (FTM) Alarm
> +
> +Required properties:
> +
> +- compatible : Should be "fsl,ftm-alarm" or "fsl,<chip>-ftm-alarm", the
> +              supported chips include
> +              "fsl,ls1012a-ftm-alarm"
> +              "fsl,ls1021a-ftm-alarm"
> +              "fsl,ls1028a-ftm-alarm"
> +              "fsl,ls1043a-ftm-alarm"
> +              "fsl,ls1046a-ftm-alarm"
> +              "fsl,ls1088a-ftm-alarm"
> +              "fsl,ls208xa-ftm-alarm"
> +- reg : Specifies base physical address and size of the register sets for the
> +  FlexTimer Module and base physical address of IP Powerdown Exception Control
> +  Register.
> +- reg-names: names of the mapped memory regions listed in regs property.
> +  should include the following entries:
> +  "ftm":    Address of the register sets for FlexTimer Module
> +  "pmctrl": Address of IP Powerdown Exception Control register

I assume we don't need this after we let the rcpm driver to deal with this.

> +- interrupts : Should be the FlexTimer Module interrupt.
> +- big-endian: If the host controller is big-endian mode, specify this property.
> +  The default endian mode is little-endian.

If it is optional as suggested by the description, put it in the
optinal property section.

> +
> +Example:
> +ftm_alarm0: timer@29d0000 {
> +       compatible = "fsl,ls1043a-ftm-alarm";
> +       reg = <0x0 0x29d0000 0x0 0x10000>,
> +             <0x0 0x1ee2140 0x0 0x4>;
> +       reg-names = "ftm", "pmctrl";
> +       interrupts = <0 86 0x4>;
> +       big-endian;
> +};
> --
> 2.7.4
>