Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
From:   Uros Bizjak <ubizjak@gmail.com>
Date:   Thu, 11 Jul 2019 10:12:55 +0200
Message-ID: <CAFULd4b=5-=WfF9OPCX+H9VDnsgbN7OBFj-XP=MZ0QqF5WpvQA@mail.gmail.com>
Subject: [RFC PATCH, x86]: Disable CPA cache flush for selfsnoop targets
To:     linux-kernel@vger.kernel.org
Cc:     x86@kernel.org, Andrew Lutomirski <luto@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>
Content-Type: multipart/mixed; boundary="000000000000188ebb058d635dff"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--000000000000188ebb058d635dff
Content-Type: text/plain; charset="UTF-8"

Recent patch [1] disabled a self-snoop feature on a list of processor
models with a known errata, so we are confident that the feature
should work on remaining models also for other purposes than to speed
up MTRR programming.

I would like to resurrect an old patch [2] that avoids calling clflush
and wbinvd
to invalidate caches when CPU supports selfsnoop.

The patch was ported to latest Fedora kernel (5.1.16) and tested with
CONFIG_CPA_DEBUG on INTEL_FAM6_IVYBRIDGE_X. The relevant ports of
dmesg show:

...
< hundreds of CPA protect messages, resulting from set_memory_rw CPA
undo test in mm/init_64.c >
CPA  protect  Rodata RO: 0xffffffffbd1fe000 - 0xffffffffbd1fefff PFN
1461fe req 8000000000000063 prevent 0000000000000002
CPA  protect  Rodata RO: 0xffff889c461fe000 - 0xffff889c461fefff PFN
1461fe req 8000000000000063 prevent 0000000000000002
Testing CPA: again
Freeing unused kernel image memory: 2016K
Freeing unused kernel image memory: 4K
x86/mm: Checked W+X mappings: passed, no W+X pages found.
rodata_test: all tests were successful
x86/mm: Checking user space page tables
x86/mm: Checked W+X mappings: passed, no W+X pages found.

and from CPA selftest:

CPA self-test:
 4k 36352 large 4021 gb 0 x 81[ffff889b00098000-ffff889bdf7ff000] miss 133120
 4k 180224 large 3740 gb 0 x 81[ffff889b00098000-ffff889bdf7ff000] miss 133120
 4k 180224 large 3740 gb 0 x 81[ffff889b00098000-ffff889bdf7ff000] miss 133120
ok.

[1] https://lkml.org/lkml/2019/6/27/828
[2] https://lkml.org/lkml/2009/4/8/508

Uros.

--000000000000188ebb058d635dff
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="0001-Disable-CPA-cache-flush-for-selfsnoop-targets.patch"
Content-Disposition: attachment; 
	filename="0001-Disable-CPA-cache-flush-for-selfsnoop-targets.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_jxye9wlt0>
X-Attachment-Id: f_jxye9wlt0

RnJvbSAxN2NiYWQ1ZDQ1YjZhZTI2ZGJjZmUwMmRlYmE1OTdjODNjZDYzYTBkIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBVcm9zIEJpemphayA8dWJpempha0BnbWFpbC5jb20+CkRhdGU6
IFdlZCwgMTAgSnVsIDIwMTkgMTU6MDE6NDQgKzAyMDAKU3ViamVjdDogW1BBVENIXSBEaXNhYmxl
IENQQSBjYWNoZSBmbHVzaCBmb3Igc2VsZnNub29wIHRhcmdldHMKClNpZ25lZC1vZmYtYnk6IFVy
b3MgQml6amFrIDx1Yml6amFrQGdtYWlsLmNvbT4KLS0tCiBhcmNoL3g4Ni9tbS9wYWdlYXR0ci5j
IHwgNyArKysrLS0tCiAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9u
cygtKQoKZGlmZiAtLWdpdCBhL2FyY2gveDg2L21tL3BhZ2VhdHRyLmMgYi9hcmNoL3g4Ni9tbS9w
YWdlYXR0ci5jCmluZGV4IDZhOWE3N2E0MDNjOS4uODg5M2VmNWY3MGNkIDEwMDY0NAotLS0gYS9h
cmNoL3g4Ni9tbS9wYWdlYXR0ci5jCisrKyBiL2FyY2gveDg2L21tL3BhZ2VhdHRyLmMKQEAgLTE3
MjUsMTAgKzE3MjUsMTEgQEAgc3RhdGljIGludCBjaGFuZ2VfcGFnZV9hdHRyX3NldF9jbHIodW5z
aWduZWQgbG9uZyAqYWRkciwgaW50IG51bXBhZ2VzLAogCQlnb3RvIG91dDsKIAogCS8qCi0JICog
Tm8gbmVlZCB0byBmbHVzaCwgd2hlbiB3ZSBkaWQgbm90IHNldCBhbnkgb2YgdGhlIGNhY2hpbmcK
LQkgKiBhdHRyaWJ1dGVzOgorCSAqIE5vIG5lZWQgdG8gZmx1c2ggd2hlbiBDUFUgc3VwcG9ydHMg
c2VsZiBzbm9vcCBvcgorCSAqIHdoZW4gd2UgZGlkIG5vdCBzZXQgYW55IG9mIHRoZSBjYWNoaW5n
IGF0dHJpYnV0ZXM6CiAJICovCi0JY2FjaGUgPSAhIXBncHJvdDJjYWNoZW1vZGUobWFza19zZXQp
OworCWNhY2hlID0gIXN0YXRpY19jcHVfaGFzKFg4Nl9GRUFUVVJFX1NFTEZTTk9PUCkgJiYKKwkJ
cGdwcm90MmNhY2hlbW9kZShtYXNrX3NldCk7CiAKIAkvKgogCSAqIE9uIGVycm9yOyBmbHVzaCBl
dmVyeXRoaW5nIHRvIGJlIHN1cmUuCi0tIAoyLjIxLjAKCg==
--000000000000188ebb058d635dff--