Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp10414220ybi; Thu, 11 Jul 2019 05:00:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqxYAU1kSOAQiq/qcByhKHVoUNOgvfwQXZKy0LvyijLaEyoIchNVQGwjDHOEGJZ07DuOsIa4 X-Received: by 2002:a17:902:86:: with SMTP id a6mr4329001pla.244.1562846437728; Thu, 11 Jul 2019 05:00:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562846437; cv=none; d=google.com; s=arc-20160816; b=jTFrxaduMBhV7dwN1IpFQLMZ7e9uJim9w3+5UWLPSP6v2zKIMN0VZVgcztTP2Y5VzO vaAdBspFvuoPbwOcjUTYrJv6utzQGNh7V4QveNa6kaS7wYbDU9IvfdN4dRO+QP6ASayo c7msTvgGSaL8hCBnah6Y3o++ucC7RovxaKJjjbAAuorTb5RZKG/OxmuEpMLFHRKheSW5 KQ6aLgHU0XRmRl0GlNGeBZeIyHmlXHhrZwk3yn4As6tedQtTE5fNYHCfmE34Zpmhchqz L6fc2PWj+VkKH/dYaoUOEtXezauxirzkUdVQpRTmOK79zxJLsmqN/40ZAf5tPHAnQv46 Zerg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=LhDp88Y3fWDqOYh1pThyRovlQ3TYPl2m85EbCDxmY+o=; b=Hijkce5EsgyRp7UNOdEmsTnU0hXGX9yPB2zbVnubaJljdHSdyxiozuMOGtJ+3nNp7Q o/39wEHXzpWmysxuVXSquR8S6o0oFMzZDLkEDzr5vkrbwODnynOvyWdKyDHWQwlqo6z2 FHbRwq3/tVJ63bG8nJU3MIUVeQ+8A733fQgGRxkipvgWTfBCUM6tRIe/JyW/VdyQuhoR P7IMnUBo4e9UuSXiYSyzdtL5ADj+E8aBlamYw7HzP+y3H5Ky2deqYR3ivLRP+39PqlL+ Q+3c3Y0eHOsLu/6d1HSxdo57AxKj87+q7fp4CPwYoG9O7XtAD0JJUZReVVoEgBvv9QRi vHTA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q5si4735813pll.279.2019.07.11.05.00.20; Thu, 11 Jul 2019 05:00:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728486AbfGKL6I (ORCPT + 99 others); Thu, 11 Jul 2019 07:58:08 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:40023 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727974AbfGKL6H (ORCPT ); Thu, 11 Jul 2019 07:58:07 -0400 Received: by mail-wr1-f66.google.com with SMTP id r1so5978020wrl.7 for ; Thu, 11 Jul 2019 04:58:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LhDp88Y3fWDqOYh1pThyRovlQ3TYPl2m85EbCDxmY+o=; b=n13M7+KGpJ8TFqztWHCBr7PNUDWRs2iuP0xdq8p7wFC4iuVNuZcGK4Nw0TdknmCS1D zO0sC2JmCC/LJ8gB+4IrCUtk+QCRepZHsBH8gz7MFUj2LqvmanXNl8nm5f54Pfu0Ru7I SsQmnhby6ky94sKDk2EkeSG5xsV18ZU2eMx52XeCEjn4W7Z7DPoOcU3/Gf+Wp6JmpvYE L7Qfgqip2jC7ZseeunKLmPKfqvNbncl7PNocDrBVSWJbK6GkTX8E74wl8ezRqPGB1Rw3 4P+aiKBBDxMdqmSWzMD/5URH88Bcxd977PCXTdscbaGlnGxxAuMcbUIkH3+5dBz62Vuf RKiw== X-Gm-Message-State: APjAAAWKTSeyNZ2DeAK7nWH+Lpxy1jE7CAqo2M0aFSPetnS6QA2dolmX gG4RobeAP9PDPwO2RHUcFtcdZA== X-Received: by 2002:adf:dcc2:: with SMTP id x2mr445302wrm.55.1562846285847; Thu, 11 Jul 2019 04:58:05 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:d066:6881:ec69:75ab? ([2001:b07:6468:f312:d066:6881:ec69:75ab]) by smtp.gmail.com with ESMTPSA id g10sm4549780wrw.60.2019.07.11.04.58.04 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 11 Jul 2019 04:58:05 -0700 (PDT) Subject: Re: [PATCH v2] KVM: x86: PMU Event Filter To: Eric Hankland , Wei Wang , rkrcmar@redhat.com Cc: linux-kernel@vger.kernel.org, Stephane Eranian , kvm@vger.kernel.org References: From: Paolo Bonzini Message-ID: <21fd772c-2267-2122-c878-f80185d8ca86@redhat.com> Date: Thu, 11 Jul 2019 13:58:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/07/19 03:25, Eric Hankland wrote: > - Add a VM ioctl that can control which events the guest can monitor. ... and finally: - the patch whitespace is damaged - the filter is leaked when the VM is destroyed - kmalloc(GFP_KERNEL_ACCOUNT) is preferrable to vmalloc because it accounts memory to the VM correctly. Since this is your first submission, I have fixed up everything. Paolo