Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp10800702ybi;
        Thu, 11 Jul 2019 11:12:12 -0700 (PDT)
X-Google-Smtp-Source: APXvYqxZJ2CMuNgKYDfO/i5yy9vQ07zPZQIEE7mh/ZOeQaXFxAg/wca67A5pMSfcF9tL0TSrbY/+
X-Received: by 2002:a63:4b02:: with SMTP id y2mr5725564pga.135.1562868731966;
        Thu, 11 Jul 2019 11:12:11 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1562868731; cv=none;
        d=google.com; s=arc-20160816;
        b=T+mL+vI+K0YnZOEEqvgOpG3K1n24yXLVFVoLc1bi5o6ZQ2JwTerrdMqUF6lIorlM1E
         FX7o+Z81WHB0cKvkZXee8jsm6R/RXxpnYXFBT9n1zMzE0/LRCYD9cdKWKo1UDrOSL1No
         Q9ftKjTkmZOGrMiaDTybAidcRckkkoogBH2N697lhixiuXVyWqODp/rIMzfqC1zNpdoz
         DId/AKezVbvzrZlIXVkSyI3oeYmR+eY9faMJlCv2GovWvh5rDEz13R187F1lVD70M9w+
         aLmh2l165KTzQPldHpwgsHTdDoDGIcpxkRiCDJHptv31XSYopT94G2FmHSeUqdx4VOUN
         xfvw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date:dkim-signature;
        bh=HFqqVAf53kQZdQpKzWHw6YV0GKjGRqkuwN0W084Idiw=;
        b=aV8jtG7CBJrp1JWZ5cEfBJfkS7Kd8l5UN27Wm/+svv5zx6FoQYR5wMDocMCGgzhw/E
         v0LE8rAH9dfXoeVT7cDxURmNMAXj7AeVRVKreI47C+Nd9/TG//H0K0FKrgndRSF26Hwl
         FmcLJz7g3WgvTNWu9ldMeu0/jsiGe4MhwyddbTxNMSzX55JelwlkUIcBpuvEeKaAJqaJ
         71zU2Hkz3vwsW2/XBadbx9oD6mMH17fj3ruXfrOLu/MxLlF71ldhJfkbGbv/0IObt3/N
         gXY9XM+PR4aqhAj8TyDfYRXykDSfCivEQw/hthRkww3/QxipZ27Y4rh5WTwxbobxnbFM
         k+Fw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=tF3TLrAg;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id 73si5913483pfa.123.2019.07.11.11.11.55;
        Thu, 11 Jul 2019 11:12:11 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=tF3TLrAg;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728966AbfGKSHb (ORCPT <rfc822;zffurovfq63@gmail.com>
        + 99 others); Thu, 11 Jul 2019 14:07:31 -0400
Received: from mail-pl1-f193.google.com ([209.85.214.193]:43305 "EHLO
        mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728304AbfGKSHb (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 11 Jul 2019 14:07:31 -0400
Received: by mail-pl1-f193.google.com with SMTP id cl9so3413329plb.10
        for <linux-kernel@vger.kernel.org>; Thu, 11 Jul 2019 11:07:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=cmpxchg-org.20150623.gappssmtp.com; s=20150623;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=HFqqVAf53kQZdQpKzWHw6YV0GKjGRqkuwN0W084Idiw=;
        b=tF3TLrAgMwyyskndvYBbdeyeiTdA3ax3J7vfMGNXEegyPwcKqVxi0vW4QF8Sbo9L5W
         6OJUTIJAIWTZ6kDHn9Rv2qLS2xtqXEkdbqacOfgHYFg6HZzoRJ/Ai5gJZYJ5hAWMIZ1i
         UykxeqaETOYUXDlhn2iVJspR45SoeMH5gfP7RQBZC0w1ekRo0mYMhWilnnztwDL99w0v
         2SQcmkV3JGGe7XtnqSV6bNjtH65hfzDSJfN5lILS8DFbRrsh5tasseTAZgiZmLzPNgyg
         lZOSsTWjhmHGGU223CWsarbZthwmuT7ikTEsPom1WpjgEWZqxirlJhjcCi7DUoxUnQv9
         XTzw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=HFqqVAf53kQZdQpKzWHw6YV0GKjGRqkuwN0W084Idiw=;
        b=WzIRMlTXlgo35RaxkjFwwXjHD00Mcl1+iO9kyULtceGkru9aTZz9OslO6IBFlj05Tu
         CYVUQU2Qlg1uHRVJ8W1WMBRbEPi6A0l65Dc2oFRkyyoGJMFlMZdTbMxgxlYmN793ctv0
         gu5e9HreV8taBOA33kieYU6jIbWa9gopTQoazaZH2hzr1xRDGkhsGnbGR06PjrxZ5V5k
         aNbpZ94c2DUxzNinkp5jHg7tWu552u8KVEByKY6O2EMjq93p3ZHEQlQ8sDZVDNbCqtR/
         q+WTboVnw0q/VyYFeoSaBwVDyJl+lH71nMUC+ElonJE9XEGBgtlNtBKmLSfvlllBBRQ4
         B17w==
X-Gm-Message-State: APjAAAWTT5av8vuPNfFZDPXSsymRvxbpF4j/38XVWekEV9YdGxWkgZpf
        7BfQUDnFSPg4jxidd1APf28=
X-Received: by 2002:a17:902:145:: with SMTP id 63mr6305306plb.55.1562868450408;
        Thu, 11 Jul 2019 11:07:30 -0700 (PDT)
Received: from localhost ([2620:10d:c091:500::2:5385])
        by smtp.gmail.com with ESMTPSA id w2sm2686882pgc.32.2019.07.11.11.07.28
        (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);
        Thu, 11 Jul 2019 11:07:29 -0700 (PDT)
Date:   Thu, 11 Jul 2019 14:07:27 -0400
From:   Johannes Weiner <hannes@cmpxchg.org>
To:     Minchan Kim <minchan@kernel.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        linux-mm <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>, linux-api@vger.kernel.org,
        Michal Hocko <mhocko@suse.com>,
        Tim Murray <timmurray@google.com>,
        Joel Fernandes <joel@joelfernandes.org>,
        Suren Baghdasaryan <surenb@google.com>,
        Daniel Colascione <dancol@google.com>,
        Shakeel Butt <shakeelb@google.com>,
        Sonny Rao <sonnyrao@google.com>, oleksandr@redhat.com,
        hdanton@sina.com, lizeb@google.com,
        Dave Hansen <dave.hansen@intel.com>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: [PATCH v4 3/4] mm: account nr_isolated_xxx in
 [isolate|putback]_lru_page
Message-ID: <20190711180727.GC20341@cmpxchg.org>
References: <20190711012528.176050-1-minchan@kernel.org>
 <20190711012528.176050-4-minchan@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190711012528.176050-4-minchan@kernel.org>
User-Agent: Mutt/1.12.0 (2019-05-25)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 11, 2019 at 10:25:27AM +0900, Minchan Kim wrote:
> The isolate counting is pecpu counter so it would be not huge gain
> to work them by batch. Rather than complicating to make them batch,
> let's make it more stright-foward via adding the counting logic
> into [isolate|putback]_lru_page API.
> 
> * v1
>  * fix accounting bug - Hillf
> 
> Link: http://lkml.kernel.org/r/20190531165927.GA20067@cmpxchg.org
> Acked-by: Michal Hocko <mhocko@suse.com>
> Suggested-by: Johannes Weiner <hannes@cmpxchg.org>
> Signed-off-by: Minchan Kim <minchan@kernel.org>

This is tricky to review, but fwiw it looks correct to me.

Acked-by: Johannes Weiner <hannes@cmpxchg.org>