Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <CAFULd4b=5-=WfF9OPCX+H9VDnsgbN7OBFj-XP=MZ0QqF5WpvQA@mail.gmail.com>
 <CALCETrXKgVMiqSfaWoBoM+WCZGHDihV8frSOdG5BFsRr2=mGJw@mail.gmail.com>
In-Reply-To: <CALCETrXKgVMiqSfaWoBoM+WCZGHDihV8frSOdG5BFsRr2=mGJw@mail.gmail.com>
From:   Uros Bizjak <ubizjak@gmail.com>
Date:   Thu, 11 Jul 2019 21:00:06 +0200
Message-ID: <CAFULd4ZgBB-VMapjY6gcTWoSKrkPx2D_KB+ov_HyC0FXLNhWBQ@mail.gmail.com>
Subject: Re: [RFC PATCH, x86]: Disable CPA cache flush for selfsnoop targets
To:     Andy Lutomirski <luto@kernel.org>
Cc:     Dave Hansen <dave.hansen@intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>, X86 ML <x86@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jul 11, 2019 at 4:39 PM Andy Lutomirski <luto@kernel.org> wrote:
>
> On Thu, Jul 11, 2019 at 1:13 AM Uros Bizjak <ubizjak@gmail.com> wrote:
> >
> > Recent patch [1] disabled a self-snoop feature on a list of processor
> > models with a known errata, so we are confident that the feature
> > should work on remaining models also for other purposes than to speed
> > up MTRR programming.
> >
> > I would like to resurrect an old patch [2] that avoids calling clflush
> > and wbinvd
> > to invalidate caches when CPU supports selfsnoop.
>
> The big question here is: what are all the reasons that we might need
> to flush?  Certainly, for stuff like SEV and MKTME, we need to flush
> regardless of any self-snoop capability.

No AMD target defines self-snoop capability, and set_memory_encrypted
forces cache clearing in __set_memory_enc_dec:

    /*
     * Before changing the encryption attribute, we need to flush caches.
     */
    cpa_flush(&cpa, 1);

Uros.