Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp156953ybi; Thu, 11 Jul 2019 16:45:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqwgTu1TJDcC/0qkkWmt7F1GBxI5QRpYhcNE8gWr1D/V8ivSnms8OA19uqjhUoXa2MeXdhq4 X-Received: by 2002:a63:f14:: with SMTP id e20mr7204268pgl.227.1562888728235; Thu, 11 Jul 2019 16:45:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562888728; cv=none; d=google.com; s=arc-20160816; b=ZUgPRXZ+1lB7NnYGSCUCUIAntJ1U+BRw6je/jV14NxSyry2LyLeQUBc4QCg1Qkj8DO N+oKqS22C5gWqqUi0Zkdtt32XpGBphrsiIrtSHITZw48ypDK4DCHg36JgCWU1IPV6t1R MAJBJhooXbreTY2n7Lb0sXatub0jdfdMXCtRHBAaLDBLk/YSoKkLxWXVX+PnxOO+mcb+ RnwlsoQcpdVsMumS6OZr+7PklrAzUSi7BBmJ6ob68OzpOJYqIQdZi2rlYB/+epPcLXHf qS9U9/mpaTfJjEWg2CNB78C9TY3KoXuqAH45bKdLR47HJlvEFIifUSil5BBr2W4Gg7Yn 4zRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=/GuW47+ITVwlHRyFWoit77iH8wSxBVV56wbG/AJ8g+A=; b=fdb+YuKeFZnPP1S72KuFxqyW1Whmhjmoqlc6dyqZyO5AUWBAPYZcP1EgDgUgjrvGTr kNSMpXPeEFh/wBW97n0x5fHxDLqU8Irmr0+rOwdpSfYW1GcNSq7F406BCv+00ELwcCVl qIFCPmjobQg/zjglM2Au3RsFV6D9q1TP2BiLjHLz7AyDprQDhOaqkqwYiNdXkVVpYe8R 1F91OC/R5KggMtVGdb/FunhefO0I6geOQSRISC0Dmv1SbhZp4N93ZLqjFago4/biTuJz g07Lxkshp1aS1bMIbjwSkqXDYnH8UlG1g3phFWVBG2XZx0cng5y/J/Y52zoKTXKCE7IS jF3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=POP2I6vc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t10si6188708pgv.139.2019.07.11.16.45.13; Thu, 11 Jul 2019 16:45:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=POP2I6vc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730485AbfGKXo3 (ORCPT + 99 others); Thu, 11 Jul 2019 19:44:29 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:37879 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729612AbfGKXoX (ORCPT ); Thu, 11 Jul 2019 19:44:23 -0400 Received: by mail-pf1-f195.google.com with SMTP id 19so3466423pfa.4 for ; Thu, 11 Jul 2019 16:44:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/GuW47+ITVwlHRyFWoit77iH8wSxBVV56wbG/AJ8g+A=; b=POP2I6vcsX7mrpLNszrDZ3jHjn5JeGjYvt0TIBarOc+TTSSHTMCxN8ZJl3umrbGe13 LL/K6XJbcw8liWBMr5VJm7tJsyYXkpeSHOo93Z5cFDVSa8Vym2EQZ+vSjFXjz8J4Wkoy ABgjJP8Cfel0JsMbqaLz7L8BjEej7RSdpehss= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/GuW47+ITVwlHRyFWoit77iH8wSxBVV56wbG/AJ8g+A=; b=fFctspVvxJFR0InUfZtyUcwatW+fJ+LKg99RoYOg9pIbu4uu8VfsEsIz9zv3M2ssIm FMEkb7jkPIgXuVTZQftVotb8hwjyp6AUZFCYYiXVR7m/7J5cd5ks9LaYjT7UaAeLghjN yXKAwmW9IiVe8H+Yv2f+LPS6rceUU+2szOOr2vw/tBFK2nTg+nuzR3JlL9P8BUTc4Umt gYggM8AJLCt0TASuOTqw5PxMY91Dht+5+JAIez5Xn5vVKyWvanRSg8IiVJd5su/p3ByK r4a/ZBFtvszRMX1PXYgDf7xiQNH79t5HcCFO1sz0eN/zCb/jAW4aafNXBSCx8A9JCD3o venA== X-Gm-Message-State: APjAAAUxruMM0lO9OdxxkrqtfBGyXEDQZlau7ZakZfO9fQXxFQn4V3yv sBJq7uH6LuHG6e3hkRWb9Lwkmv7Q X-Received: by 2002:a63:3f48:: with SMTP id m69mr7029829pga.17.1562888662320; Thu, 11 Jul 2019 16:44:22 -0700 (PDT) Received: from joelaf.cam.corp.google.com ([2620:15c:6:12:9c46:e0da:efbf:69cc]) by smtp.gmail.com with ESMTPSA id t10sm6163450pjr.13.2019.07.11.16.44.18 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 11 Jul 2019 16:44:21 -0700 (PDT) From: "Joel Fernandes (Google)" To: linux-kernel@vger.kernel.org Cc: "Joel Fernandes (Google)" , Alexey Kuznetsov , Bjorn Helgaas , Borislav Petkov , c0d1n61at3@gmail.com, "David S. Miller" , edumazet@google.com, Greg Kroah-Hartman , Hideaki YOSHIFUJI , "H. Peter Anvin" , Ingo Molnar , Josh Triplett , keescook@chromium.org, kernel-hardening@lists.openwall.com, Lai Jiangshan , Len Brown , linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, Mathieu Desnoyers , neilb@suse.com, netdev@vger.kernel.org, oleg@redhat.com, "Paul E. McKenney" , Pavel Machek , peterz@infradead.org, "Rafael J. Wysocki" , Rasmus Villemoes , rcu@vger.kernel.org, Steven Rostedt , Tejun Heo , Thomas Gleixner , will@kernel.org, x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)) Subject: [PATCH v1 2/6] ipv4: add lockdep condition to fix for_each_entry Date: Thu, 11 Jul 2019 19:43:57 -0400 Message-Id: <20190711234401.220336-3-joel@joelfernandes.org> X-Mailer: git-send-email 2.22.0.410.gd8fdbe21b5-goog In-Reply-To: <20190711234401.220336-1-joel@joelfernandes.org> References: <20190711234401.220336-1-joel@joelfernandes.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Signed-off-by: Joel Fernandes (Google) --- net/ipv4/fib_frontend.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c index b298255f6fdb..ef7c9f8e8682 100644 --- a/net/ipv4/fib_frontend.c +++ b/net/ipv4/fib_frontend.c @@ -127,7 +127,8 @@ struct fib_table *fib_get_table(struct net *net, u32 id) h = id & (FIB_TABLE_HASHSZ - 1); head = &net->ipv4.fib_table_hash[h]; - hlist_for_each_entry_rcu(tb, head, tb_hlist) { + hlist_for_each_entry_rcu(tb, head, tb_hlist, + lockdep_rtnl_is_held()) { if (tb->tb_id == id) return tb; } -- 2.22.0.410.gd8fdbe21b5-goog