Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp200157ybi; Thu, 11 Jul 2019 17:40:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqzkaMcbt77e7HbzKeEnBjuq0yq2Y9gYAFbcmcsG5HJBZPYlXGxLSV/9ZFhppcPUcREH3497 X-Received: by 2002:a17:902:e30d:: with SMTP id cg13mr7809292plb.173.1562892014003; Thu, 11 Jul 2019 17:40:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562892013; cv=none; d=google.com; s=arc-20160816; b=LDJoJlaxG/j3N5oXVaf3+jcmzpsQeHxSRA2FAM71zb3r4KH1ZasKwwBDYOpmdg/O91 Iy7MWOiyPob9ndb7KckZvNCXyOsDSiW+rZQORDWHuF3+lT5R9JysCfSfrftgQeUDDLAP q9q0BEChWPZZFel+QeeQfjScOAFMtbN/cDZD4gjcCcNwYK12zDR9IW2ALQg64rUmNBaO Va8yIlbh6xnvWT0ZkfH/+qlFUdB5mbbg8BDpgeCJHa1eBCq5EJ3urZvDCfmOBEYk3h1V uhstdOMPuini1Ad8KiGZDPHG/lpFcLxi+tRHzOZsdOZ1qsUYSplLboJiQXaY6wF6rEOv +5lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=3YQo0ogAq7ZhlFyUYP1eMcCPQV10NpbRaXAOsP9YmaA=; b=G9Ef/fyVKAaAYGjX8Hi4kh8Paua88TYapHelwS+gd/aLQNDm9IhIMaSN5zVMVGu7is i457x9HoZlg6hXd6LcUB3epFfY3AWSDA49G8ZG4WMEBU1zHdpWKkRJemL2Uq14z+rYMp /otZE1n2T3ELvR1cFixyqQaYhM/fIxScz/LBg0IIvFnMmUfM5atKgLReRKy94NACLsd7 7U1J2365LZwYr+IQL4ll2zq9z9l94Mfp0wPiajetgZxNjb784GCLYtq0ZyCsMOOGVbXP hGuzSG/20NH+PvXL7BCYOg/M+jTETvDlzlmj1GB8LTuY/fhIpOPoS+v5YVSG39y0rx4l f1tA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=C8bCwhVH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r33si6801211pgm.371.2019.07.11.17.39.57; Thu, 11 Jul 2019 17:40:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=C8bCwhVH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728748AbfGLAiw (ORCPT + 99 others); Thu, 11 Jul 2019 20:38:52 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:50782 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726199AbfGLAiw (ORCPT ); Thu, 11 Jul 2019 20:38:52 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x6C0XsBO179766; Fri, 12 Jul 2019 00:38:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=3YQo0ogAq7ZhlFyUYP1eMcCPQV10NpbRaXAOsP9YmaA=; b=C8bCwhVH8dhIuv4jB1nHG1qE69l+u88NRWGuVFgVjbbGFEGu4x6356wBO3V2xhlVZRki JVNqyNXi5cn9K/T1xfQo4PDGHy/olQLriozJD+EO99fYmjF9FO//ENiRoJQp6UYvfOuY nbWc8ETbjVg7NdvBi4oPxrZOWQjSIXyU1KyfcPonmgw25q4HkAZiZrkAlY94gu9CtcfF dRDywx4vZpAE4fal5LDuOgCL5FywZI8ue26XqM7NwyTLgR2iZkKFka6tlCCyXd2fEaqJ swIFgPgEZJPY75XCNNEp+QIu1s94y/4tBBulPIuxdHK0WiK0PqCwy6VhpDMXzGT5pXK4 gQ== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 2tjkkq2uve-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 12 Jul 2019 00:38:49 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x6C0cBZL089169; Fri, 12 Jul 2019 00:38:48 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3020.oracle.com with ESMTP id 2tnc8tuctf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 12 Jul 2019 00:38:48 +0000 Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x6C0clYB004447; Fri, 12 Jul 2019 00:38:47 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 11 Jul 2019 17:38:47 -0700 To: James Bottomley Cc: Keyur Patel , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: aha1740: Use !x in place of NULL comparisons From: "Martin K. Petersen" Organization: Oracle Corporation References: <20190711234833.27475-1-iamkeyur96@gmail.com> <1562889124.2915.5.camel@linux.ibm.com> Date: Thu, 11 Jul 2019 20:38:45 -0400 In-Reply-To: <1562889124.2915.5.camel@linux.ibm.com> (James Bottomley's message of "Thu, 11 Jul 2019 16:52:04 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9315 signatures=668688 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=815 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907120006 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9315 signatures=668688 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=882 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907120005 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org James, > I also don't really think the replacement adds anything to readability, > so it should probably be removed from the checkpatch warnings. I agree. -- Martin K. Petersen Oracle Linux Engineering