Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (1.0)
Subject: Re: [RFC v2 02/26] mm/asi: Abort isolation on interrupt, exception and context switch
From:   Andy Lutomirski <luto@amacapital.net>
In-Reply-To: <1562855138-19507-3-git-send-email-alexandre.chartre@oracle.com>
Date:   Thu, 11 Jul 2019 18:05:58 -0600
Cc:     pbonzini@redhat.com, rkrcmar@redhat.com, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, hpa@zytor.com,
        dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org,
        kvm@vger.kernel.org, x86@kernel.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, konrad.wilk@oracle.com,
        jan.setjeeilers@oracle.com, liran.alon@oracle.com,
        jwadams@google.com, graf@amazon.de, rppt@linux.vnet.ibm.com
Content-Transfer-Encoding: quoted-printable
Message-Id: <B8AF6DF6-8D39-40F6-8624-6F67EDA4E390@amacapital.net>
References: <1562855138-19507-1-git-send-email-alexandre.chartre@oracle.com> <1562855138-19507-3-git-send-email-alexandre.chartre@oracle.com>
To:     Alexandre Chartre <alexandre.chartre@oracle.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On Jul 11, 2019, at 8:25 AM, Alexandre Chartre <alexandre.chartre@oracle.c=
om> wrote:
>=20
> Address space isolation should be aborted if there is an interrupt,
> an exception or a context switch. Interrupt/exception handlers and
> context switch code need to run with the full kernel address space.
> Address space isolation is aborted by restoring the original CR3
> value used before entering address space isolation.
>=20

NAK to the entry changes. That code you=E2=80=99re changing is already known=
 to be a bit buggy, and it=E2=80=99s spaghetti. PeterZ and I are gradually w=
orking on fixing some bugs and C-ifying it. ASI can go on top.