Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp236869ybi; Thu, 11 Jul 2019 18:29:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqzAXZxOCAudJJZZJsyVcFVRW6kcYLYJR6UFzOGV4h5AXn9n1M4REu7dMLa0QOeQZImr16I1 X-Received: by 2002:a65:6294:: with SMTP id f20mr7793613pgv.349.1562894942253; Thu, 11 Jul 2019 18:29:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562894942; cv=none; d=google.com; s=arc-20160816; b=FYM2WLbFvyB0RdznOciPsb3dVh90a+nCV3XeFDorIySzMggjiPpBCsQaKG6gM3dJDx JKZVfasv/sPWG7TcqwDsYlL72AWz5zul40QJXAufhlMp8mzHy7Fnu7A2E1Ntl1+9djiY oHOn4QifKLlkYOCDPzTdl4HEa66nqKDoG60wA7Zm2773g0V5czs0ICDdp2HdMQRoKg3P Q2ouCmz3gg3v7z0wntG6lAeZb7rI0PUaFBVdvXNRamOSv8ghIO+rfZplOFUzETCfDHlT 30QrE9d5I08+r1VcwXa2wneXVpGO0rq5Q/FEZaRZRu0YrwX1npGaefdNbWSZH9Y7hnzO YAVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=MyqDzkjr6SgCOR0LE/p7Ro+E9veAx/FsFO0PJBP+zok=; b=pk7nTUtvmMXvyRNX9NY0za/byssN4oIg5ts1VfMMK/RJL48bFmfB18qI6DPAvPdd1x rlWiOzR3IaTYpr4NSE1pDqLS1ejfhilm9QeoSjp7xu1JrVLzJ02LXOhBY3oHFDXQxG60 /Ua7UUlilJ2YxZqjZY4VVIX1w/quMiSWqATLjUI3nZo9fcp1qJZ/ZJzI1IaYDRjt3U+7 rg9aSqX94uU3HyH6aGPe5LB1B6toD3gIGaxHGLAx/ZS9H0W9xwN4iwgMtfSC9MPZmYdu SNPT9uC7fJRHz8ZVHgtPPgo59atNX5UPSyFLK6Pspa30tHH3sMcG/5ghq+9rr+3O9sS8 62rg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=s5I2SykH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w64si2777580pgd.2.2019.07.11.18.28.45; Thu, 11 Jul 2019 18:29:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=s5I2SykH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729049AbfGLBKc (ORCPT + 99 others); Thu, 11 Jul 2019 21:10:32 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:49122 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728683AbfGLBKc (ORCPT ); Thu, 11 Jul 2019 21:10:32 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x6C190T8103427; Fri, 12 Jul 2019 01:10:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=MyqDzkjr6SgCOR0LE/p7Ro+E9veAx/FsFO0PJBP+zok=; b=s5I2SykHMCXqEKOJBy+AJJiVoPi4G/NP6r2DM0Eq2+GncPYd8f7rzXC+Bqz2b/0Rv+z6 q+kB9aAHxHogHjX+SxApdt4Gh0ZHq8tuaVp5gMWUCH6iCa/XyjOLZ/Q+MfYtcP3sGxns 1tPTaWWPCynTX6hKISSVVtmB6bVxSPSihvUVvN7mQn9I+3+8wLalStvf0lNZ7GjVz+Cw rse1LMOx+srzvzC4E7Bdfdt6f5xtsiMi+7BwwwK99NdLoLzmK2R5M5XV+oU1DgBzJIvz CavZxOTXPAM/nv20+yD9Jq68Nm36y1uPN8LT775qaQV1O48pEYmJuUgbuvuLhtMwwlDA DQ== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 2tjk2u30a6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 12 Jul 2019 01:10:24 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x6C17qkn178549; Fri, 12 Jul 2019 01:10:24 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3020.oracle.com with ESMTP id 2tnc8tv0d5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 12 Jul 2019 01:10:24 +0000 Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x6C1AMmt001737; Fri, 12 Jul 2019 01:10:23 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 11 Jul 2019 18:10:22 -0700 To: Wenwen Wang Cc: Wenwen Wang , Jens Axboe , linux-block@vger.kernel.org (open list:BLOCK LAYER), linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH v2] block/bio-integrity: fix a memory leak bug From: "Martin K. Petersen" Organization: Oracle Corporation References: <1562872923-2463-1-git-send-email-wang6495@umn.edu> Date: Thu, 11 Jul 2019 21:10:20 -0400 In-Reply-To: <1562872923-2463-1-git-send-email-wang6495@umn.edu> (Wenwen Wang's message of "Thu, 11 Jul 2019 14:22:02 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9315 signatures=668688 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=2 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=779 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907120013 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9315 signatures=668688 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=846 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907120013 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Wenwen, > To fix this issue, free the allocated buffer before returning from > bio_integrity_prep(). Acked-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering