Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2] block/bio-integrity: fix a memory leak bug
To:     Wenwen Wang <wang6495@umn.edu>, Wenwen Wang <wenwen@cs.uga.edu>
Cc:     "open list:BLOCK LAYER" <linux-block@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
References: <1562872923-2463-1-git-send-email-wang6495@umn.edu>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <956286e2-06fc-4d43-e78e-8f2059292aab@kernel.dk>
Date:   Thu, 11 Jul 2019 20:02:10 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <1562872923-2463-1-git-send-email-wang6495@umn.edu>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 7/11/19 1:22 PM, Wenwen Wang wrote:
> From: Wenwen Wang <wenwen@cs.uga.edu>
> 
> In bio_integrity_prep(), a kernel buffer is allocated through kmalloc() to
> hold integrity metadata. Later on, the buffer will be attached to the bio
> structure through bio_integrity_add_page(), which returns the number of
> bytes of integrity metadata attached. Due to unexpected situations,
> bio_integrity_add_page() may return 0. As a result, bio_integrity_prep()
> needs to be terminated with 'false' returned to indicate this error.
> However, the allocated kernel buffer is not freed on this execution path,
> leading to a memory leak.
> 
> To fix this issue, free the allocated buffer before returning from
> bio_integrity_prep().

Applied, thanks.

-- 
Jens Axboe