Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp339550ybi; Thu, 11 Jul 2019 20:30:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqzoLRtlheaASSmVmwT27rdf43aMh+1lV2hK/J9lBcQWUm283SSGSw82eoARITcloS2Xez/n X-Received: by 2002:a63:f14:: with SMTP id e20mr8171255pgl.227.1562902235090; Thu, 11 Jul 2019 20:30:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562902235; cv=none; d=google.com; s=arc-20160816; b=KkeSb56dt5HZq0uMBb9Qb+QwMNx4WbfLA3Ejq8mEix283k7aMCTUb0i36lyAMgaCAa z2t0Z7/B4OLPTEhiMwqrCzi1vdbZ8NadI4qfsIxFUy3lbqfaCo/Y7AcU89mEJ/mR91rL SN54VBJdsy5nKq/gyRU/mBgqzlYpsl5d0pJBJClqDVp/HPyweFBrhIQGuUfbi+v4Mv2E zWh32Z7yxIrq2eM9gXOYERxSH0rXVgbaOC+UaJeP315do5EUxd3RjAsHpPC1w7o8hi2b 8uhpRkddBh5O9Y/jkVD4dc22kpW+IVfFy09wXcD2HJeScPEY5/959MDrLSYLiw2S8RqM jjkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=FtYvCUVOhKvvIV0H50JdfoJGret/1GUMnmCK8ALLtAo=; b=BfYWO3r06RP5aHgqHi7mScncamIXgwfH1RisSTT3xs6JNRJoC3ik3z9YLuzlDoJ3FA MemudgX3IpWGyMTnsZD0cm/7koLQCsf9R6YW/YG9194gsiy9NE2TlRHEexo4x9DhbjpP Tvqki/1ZEAeK3GNkqdOiEBlwDACAxybIKfNCFaiQHXQRy8gIV+Ksp210uqeelZIYOTLO oQFXEUP3W7BRIBCBf5dnCqFtR+jHXLQyQpWPj/hx6OB23DR4yG5XSegk02KV4/Gmh4+z jNmL/uHSAsLrklpegAwHPHmQKQzTMaPhnXOwkTuT89AjXNLtinS17xZ2ng0+seEUp7jA XWuw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 6si6448936plb.345.2019.07.11.20.30.18; Thu, 11 Jul 2019 20:30:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729343AbfGLD3t (ORCPT + 99 others); Thu, 11 Jul 2019 23:29:49 -0400 Received: from namei.org ([65.99.196.166]:34804 "EHLO namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728955AbfGLD3t (ORCPT ); Thu, 11 Jul 2019 23:29:49 -0400 Received: from localhost (localhost [127.0.0.1]) by namei.org (8.14.4/8.14.4) with ESMTP id x6C3TXIY022499; Fri, 12 Jul 2019 03:29:33 GMT Date: Fri, 12 Jul 2019 13:29:32 +1000 (AEST) From: James Morris To: Casey Schaufler cc: Aaron Goidel , paul@paul-moore.com, selinux@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, dhowells@redhat.com, jack@suse.cz, amir73il@gmail.com, sds@tycho.nsa.gov, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] fanotify, inotify, dnotify, security: add security hook for fs notifications In-Reply-To: <4fd98c88-61a6-a155-5028-db22a778d3c1@schaufler-ca.com> Message-ID: References: <20190710133403.855-1-acgoide@tycho.nsa.gov> <4fd98c88-61a6-a155-5028-db22a778d3c1@schaufler-ca.com> User-Agent: Alpine 2.21 (LRH 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 10 Jul 2019, Casey Schaufler wrote: > On 7/10/2019 6:34 AM, Aaron Goidel wrote: > > > Furthermore, fanotify watches grant more power to > > an application in the form of permission events. While notification events > > are solely, unidirectional (i.e. they only pass information to the > > receiving application), permission events are blocking. Permission events > > make a request to the receiving application which will then reply with a > > decision as to whether or not that action may be completed. > > You're not saying why this is an issue. Also in the description, please explain the issues with read and write notifications and why a simple 'read' permission is not adequate. -- James Morris