Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   12 Jul 2019 12:37:51 +0900
Message-ID: <87muhk53j1.wl-kuninori.morimoto.gx@renesas.com>
From:   Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To:     Nathan Chancellor <natechancellor@gmail.com>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Wen Yang <wen.yang99@zte.com.cn>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com
Subject: Re: [PATCH v2] ASoC: audio-graph-card: Constify reg in graph_get_dai_id
In-Reply-To: <20190712014554.62465-1-natechancellor@gmail.com>
References: <20190712014357.84245-1-natechancellor@gmail.com>
        <20190712014554.62465-1-natechancellor@gmail.com>
User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Hi Nathan

> clang errors:
> 
> sound/soc/generic/audio-graph-card.c:87:7: error: assigning to 'u32 *'
> (aka 'unsigned int *') from 'const void *' discards qualifiers
> [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
>                 reg = of_get_property(node, "reg", NULL);
>                     ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 1 error generated.
> 
> Move the declaration up a bit to keep the reverse christmas tree look.
> 
> Fixes: c152f8491a8d ("ASoC: audio-graph-card: fix an use-after-free in graph_get_dai_id()")
> Link: https://github.com/ClangBuiltLinux/linux/issues/600
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---

Maybe

ec3042ad39d4e2ddbc3a3344f90bb10d8feb53bc
("ASoC: audio-graph-card: add missing const at graph_get_dai_id()")

Thank you for your help !!
Best regards
---
Kuninori Morimoto