Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 12 Jul 2019 09:21:45 +0200
From:   Maxime Ripard <maxime.ripard@bootlin.com>
To:     Zeng Tao <prime.zeng@hisilicon.com>
Cc:     kishon@ti.com, Chen-Yu Tsai <wens@csie.org>,
        Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] phy: Change the configuration interface param to void*
 to make it more general
Message-ID: <20190712072145.gr3dbfvdfgrye6yi@flea>
References: <1562923580-47746-1-git-send-email-prime.zeng@hisilicon.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="q4ycfudq7dncn663"
Content-Disposition: inline
In-Reply-To: <1562923580-47746-1-git-send-email-prime.zeng@hisilicon.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--q4ycfudq7dncn663
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jul 12, 2019 at 05:26:04PM +0800, Zeng Tao wrote:
> The phy framework now allows runtime configurations, but only limited
> to mipi now, and it's not reasonable to introduce user specified
> configurations into the union phy_configure_opts structure. An simple
> way is to replace with a void *.
>
> We have already got some phy drivers which introduce private phy API
> for runtime configurations, and with this patch, they can switch to
> the phy_configure as a replace.
>
> Signed-off-by: Zeng Tao <prime.zeng@hisilicon.com>

I still don't believe this is the right approach, for the reasons
exposed in my first review of that patch.

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

--q4ycfudq7dncn663
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXSg1CQAKCRDj7w1vZxhR
xcl7AQD/l+gpdt4tLbilzX+6ZMKAGS3WAQO2akmyeVmUZrz6cwEA9wIVIvz4R8Zy
JSba5uROdmHDOd3ljw0dOctpSOHXmAw=
=FZ3v
-----END PGP SIGNATURE-----

--q4ycfudq7dncn663--