Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp593571ybi; Fri, 12 Jul 2019 01:23:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqzcCgEHcVWCDyp5PKddXIiHkLK+QoJ+FRPuNxW1Wok+CTMI8lgonCe9XejYn2/XcLWW4srz X-Received: by 2002:a17:90a:a116:: with SMTP id s22mr10054032pjp.47.1562919799075; Fri, 12 Jul 2019 01:23:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562919799; cv=none; d=google.com; s=arc-20160816; b=hE/HNGgPMtw3aIokWkqBZMRnNwUb44UjHjMDAxXXHyKa9rKp8J3vye6LlcRytyzr9c Z3uUUMUIKhcwWTXrNqPJyiejkD07em4CGj1NbuEZ4qMwEifC5I1DY7lMMqi37EfxS4ML 5oTt6B66weNunT0XOGGgqt/1/L1TOJuc5rMWw4vHy82w8FILZNYMcTE2jh7ojD0h1b3L VGmi6Dei9C58vHQs2k3fPnw1fgiLGZ1VuYBEt2XXoBH0NG6zRPDcMl4/8JWikCYKKdcL 80MwtiFXnh7ebS+oyN3N7fRONfwv9y6A+7ovCY1+9LixI2C2PQ43CAGlUHuiLZVuz+hF q9kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:ironport-sdr; bh=XDBRXg2O90soND/3B6DZ2aCwD+Qf+YTXslv5j9kfEy4=; b=ftn+QbRMEngyqX6xUxrAq7Z2LH1WwUBn748usPjdnI2JBRa6iY7w6um2E3J0+AXYJA uJ83FNHaKJodKz3omYGqu9AEkdbQDfPSwKsqAYYIXD8X0tG64CEhWxL0/ff/nxuCbr0L SSz6LebF7PgHcVBYMTfc8wvpV5F4t0C00RWoF/fLn8wTEUKa4itAEDaD4mmOd4S7vQca Ns4hsyJeUhqtVLgSskwzvw2y5cmNmOkvqueJ2TpKpw5MRuiqlU5BsRgbGK4ahIJqg7p1 ND2xBZ+VwFq7HXQQ5rVjMmOmBo2WUUsWMQR0nzgf0dA7gjbPMYTmnybBHe7Lg7KsGIWU nV9g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=microchip.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m17si7911301pgg.539.2019.07.12.01.23.03; Fri, 12 Jul 2019 01:23:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=microchip.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726641AbfGLIVg (ORCPT + 99 others); Fri, 12 Jul 2019 04:21:36 -0400 Received: from esa3.microchip.iphmx.com ([68.232.153.233]:31655 "EHLO esa3.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726057AbfGLIVf (ORCPT ); Fri, 12 Jul 2019 04:21:35 -0400 Received-SPF: Pass (esa3.microchip.iphmx.com: domain of Ludovic.Desroches@microchip.com designates 198.175.253.82 as permitted sender) identity=mailfrom; client-ip=198.175.253.82; receiver=esa3.microchip.iphmx.com; envelope-from="Ludovic.Desroches@microchip.com"; x-sender="Ludovic.Desroches@microchip.com"; x-conformance=spf_only; x-record-type="v=spf1"; x-record-text="v=spf1 mx a:ushub1.microchip.com a:smtpout.microchip.com a:mx1.microchip.iphmx.com a:mx2.microchip.iphmx.com include:servers.mcsv.net include:mktomail.com include:spf.protection.outlook.com ~all" Received-SPF: None (esa3.microchip.iphmx.com: no sender authenticity information available from domain of postmaster@email.microchip.com) identity=helo; client-ip=198.175.253.82; receiver=esa3.microchip.iphmx.com; envelope-from="Ludovic.Desroches@microchip.com"; x-sender="postmaster@email.microchip.com"; x-conformance=spf_only Authentication-Results: esa3.microchip.iphmx.com; dkim=none (message not signed) header.i=none; spf=Pass smtp.mailfrom=Ludovic.Desroches@microchip.com; spf=None smtp.helo=postmaster@email.microchip.com; dmarc=pass (p=none dis=none) d=microchip.com IronPort-SDR: 0nKJFzhFvuZ347cB/1iiOa0gusRvfdBglhNi2o0z9N/fIyHAPcTdgecYmTmIkYUI0QIejHKQnG +f+1HheYLXKArKACJuXk7O2Uhe86jslFjq2mI57IY0bNjUxlg1tw2eCrM5ZmUUcF5ccyiU5giF gmrGI4Ne4wsOcSl9iMxQ9cRI+UaJ7jEMD+4oxeIVy+JBNiGrVxRQSwpBrRpKH6To1dDo9+3TFP ehkXFDSs9lCGlYq9Tf260yBnuier1zs8uLlkU4Z/LtPRITUYb3LuxVU0QLiupiyuj27Vkfr6wz tf8= X-IronPort-AV: E=Sophos;i="5.63,481,1557212400"; d="scan'208";a="41053477" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 12 Jul 2019 01:21:34 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.87.71) by chn-vm-ex04.mchp-main.com (10.10.87.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 12 Jul 2019 01:21:33 -0700 Received: from localhost (10.10.85.251) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Fri, 12 Jul 2019 01:21:31 -0700 Date: Fri, 12 Jul 2019 10:20:44 +0200 From: Ludovic Desroches To: Eugen Hristev - M18282 CC: "wsa@the-dreams.de" , "peda@axentia.se" , "mark.rutland@arm.com" , "linux-i2c@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "pierre-yves.mordret@st.com" , "alexandre.belloni@bootlin.com" , "robh+dt@kernel.org" , Nicolas Ferre - M43238 Subject: Re: [PATCH v3 0/9] i2c: add support for filters Message-ID: <20190712082044.6eteunzehyptsibk@M43218.corp.atmel.com> Mail-Followup-To: Eugen Hristev - M18282 , "wsa@the-dreams.de" , "peda@axentia.se" , "mark.rutland@arm.com" , "linux-i2c@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "pierre-yves.mordret@st.com" , "alexandre.belloni@bootlin.com" , "robh+dt@kernel.org" , Nicolas Ferre - M43238 References: <1562678049-17581-1-git-send-email-eugen.hristev@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1562678049-17581-1-git-send-email-eugen.hristev@microchip.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 09, 2019 at 03:19:26PM +0200, Eugen Hristev - M18282 wrote: > From: Eugen Hristev > > Hello, > > This series adds support for analog and digital filters for i2c controllers > > This series is based on the series: > [PATCH v2 0/9] i2c: at91: filters support for at91 SoCs > and enhanced to add the bindings for all controllers plus an extra binding > for the width of the spikes in nanoseconds. > > First, bindings are created for > 'i2c-ana-filter' > 'i2c-dig-filter' > 'i2c-filter-width-ns' > > The support is added in the i2c core to retrieve filter width and add it > to the timings structure. > Next, the at91 driver is enhanced for supporting digital filter, advanced > digital filter (with selectable spike width) and the analog filter. > > Finally the device tree for two boards are modified to make use of the > new properties. > > This series is the result of the comments on the ML in the direction > requested: to make the bindings globally available for i2c drivers. > > Changes in v3: > - made bindings global for i2c controllers and modified accordingly > - gave up PADFCDF bit because it's a lack in datasheet > - the computation on the width of the spike is based on periph clock as it > is done for hold time. > > Changes in v2: > - added device tree bindings and support for enable-ana-filt and > enable-dig-filt > - added the new properties to the DT for sama5d4_xplained/sama5d2_xplained > > Eugen Hristev (9): > dt-bindings: i2c: at91: add new compatible > dt-bindings: i2c: add bindings for i2c analog and digital filter > i2c: add support for filter-width-ns optional property > i2c: at91: add new platform support for sam9x60 > i2c: at91: add support for digital filtering > i2c: at91: add support for advanced digital filtering > i2c: at91: add support for analog filtering > ARM: dts: at91: sama5d2_xplained: add analog and digital filter for > i2c > ARM: dts: at91: sama5d4_xplained: add analog filter for i2c > > Documentation/devicetree/bindings/i2c/i2c-at91.txt | 3 +- > Documentation/devicetree/bindings/i2c/i2c.txt | 11 +++++ > arch/arm/boot/dts/at91-sama5d2_xplained.dts | 6 +++ > arch/arm/boot/dts/at91-sama5d4_xplained.dts | 1 + > drivers/i2c/busses/i2c-at91-core.c | 38 +++++++++++++++++ > drivers/i2c/busses/i2c-at91-master.c | 49 ++++++++++++++++++++-- > drivers/i2c/busses/i2c-at91.h | 13 ++++++ > drivers/i2c/i2c-core-base.c | 2 + > include/linux/i2c.h | 2 + > 9 files changed, 121 insertions(+), 4 deletions(-) Hi, I don't know if it will fit other vendors need concerning the binding but for Microchip it sounds good. Acked-by: Ludovic Desroches for the whole serie. Regards Ludovic