Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 12 Jul 2019 11:35:44 +0200
From:   Jan Kara <jack@suse.cz>
To:     Pali =?iso-8859-1?Q?Roh=E1r?= <pali.rohar@gmail.com>
Cc:     "Steven J. Magnani" <steve.magnani@digidescorp.com>,
        "Steven J . Magnani" <steve@digidescorp.com>,
        Jan Kara <jack@suse.com>, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] udf: refactor VRS descriptor identification
Message-ID: <20190712093544.GE906@quack2.suse.cz>
References: <20190711133852.16887-1-steve@digidescorp.com>
 <20190711181521.fqsbatc2oslo2v5t@pali>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20190711181521.fqsbatc2oslo2v5t@pali>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu 11-07-19 20:15:21, Pali Roh?r  wrote:
> On Thursday 11 July 2019 08:38:51 Steven J. Magnani wrote:
> > --- a/fs/udf/super.c	2019-07-10 18:57:41.192852154 -0500
> > +++ b/fs/udf/super.c	2019-07-10 20:47:50.438352500 -0500
> > @@ -685,16 +685,62 @@ out_unlock:
> >  	return error;
> >  }
> >  
> > -/* Check Volume Structure Descriptors (ECMA 167 2/9.1) */
> > -/* We also check any "CD-ROM Volume Descriptor Set" (ECMA 167 2/8.3.1) */
> > -static loff_t udf_check_vsd(struct super_block *sb)
> > +static int identify_vsd(const struct volStructDesc *vsd)
> > +{
> > +	int vsd_id = 0;
> > +
> > +	if (!strncmp(vsd->stdIdent, VSD_STD_ID_CD001, VSD_STD_ID_LEN)) {
> 
> Hi! You probably want to use memcmp() instead of strncmp().

There's no difference in functionality but I agree it makes more sense.
I'll modify the patch. Thanks for review!

								Honza

> 
> > +		switch (vsd->structType) {
> > +		case 0:
> > +			udf_debug("ISO9660 Boot Record found\n");
> > +			break;
> > +		case 1:
> > +			udf_debug("ISO9660 Primary Volume Descriptor found\n");
> > +			break;
> > +		case 2:
> > +			udf_debug("ISO9660 Supplementary Volume Descriptor found\n");
> > +			break;
> > +		case 3:
> > +			udf_debug("ISO9660 Volume Partition Descriptor found\n");
> > +			break;
> > +		case 255:
> > +			udf_debug("ISO9660 Volume Descriptor Set Terminator found\n");
> > +			break;
> > +		default:
> > +			udf_debug("ISO9660 VRS (%u) found\n", vsd->structType);
> > +			break;
> > +		}
> > +	} else if (!strncmp(vsd->stdIdent, VSD_STD_ID_BEA01, VSD_STD_ID_LEN))
> > +		vsd_id = 1;
> > +	else if (!strncmp(vsd->stdIdent, VSD_STD_ID_NSR02, VSD_STD_ID_LEN))
> > +		vsd_id = 2;
> > +	else if (!strncmp(vsd->stdIdent, VSD_STD_ID_NSR03, VSD_STD_ID_LEN))
> > +		vsd_id = 3;
> > +	else if (!strncmp(vsd->stdIdent, VSD_STD_ID_BOOT2, VSD_STD_ID_LEN))
> > +		; /* vsd_id = 0 */
> > +	else if (!strncmp(vsd->stdIdent, VSD_STD_ID_CDW02, VSD_STD_ID_LEN))
> > +		; /* vsd_id = 0 */
> > +	else {
> > +		/* TEA01 or invalid id : end of volume recognition area */
> > +		vsd_id = 255;
> > +	}
> > +
> > +	return vsd_id;
> > +}
> 
> -- 
> Pali Roh?r
> pali.rohar@gmail.com


-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR