Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp838433ybi; Fri, 12 Jul 2019 05:30:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqx51rp5KXvcsTUoU5a/ZBPVK64p1PsB63U6u95fvtrEhWm1aAmwODITSW2B6Xrt2xd5Q94q X-Received: by 2002:a63:5b52:: with SMTP id l18mr10616793pgm.21.1562934601081; Fri, 12 Jul 2019 05:30:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562934601; cv=none; d=google.com; s=arc-20160816; b=txjcidXPbGPFCjNNvjpVYYsbplVzXeLxUKPiFQPdEWkKbaUjgpnhepD+4+L743qyoi f4WbelG3iFV3rQogQHOC088rGq+6mDG6AEraBHBcybWph/jbah1Ttcrt8wqdPlaS1+Bu 3gxb8QrsaXfondaDvtn8TRa4wtg18fOfzDjgpVCgNBfaHQ2vf8eYiGlhq3WPBoT4AVH+ NppeYvgA11Cah/nSqMd4Q68ABOxm2eslEbHzP1ZUk/ieLEM6iI9X8bfpc01Zl7jjeVfM fKeuFBvMPRumUkhDToGu+U4lLa/RUDBzuAkziA3ADXF1s3PmzDjCNkYeSxmXvMqoZIpZ Ol7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=tiVzofosXclkhcSRcsS9AE16AmXOkIYSivUTl4rq6NU=; b=1HrPNFdVgsF2SNwi8ZH2ra/qn5G5W2RCUDj2uf+zZ7F85Vy7GWyva8VNF+Ub846x8L jnkxkCpF0gK+dpU5GZfi9GoAIpDmvGCiyM0MFiaPu/K2Lqe1OIvqt35IPVFCPCkR/b75 ED3CMTwbN0YGZDw4A72UTogQeO6ZUOxeEnwttcngXPh9GYk19f6m276VYKWLUgOUeNak +Lv+NxtE+j+YJ4eDjG2QpwxuSOAGsx4mW8OYR9pIbGaaYmbOoIj5/FuX1TazAC8LU0FY SINshVMc4oknP4JZFY9lYuM40qUlPhvwj1aEM6JVeyON2R0g2WM3VtUbWVAdCmg/yh9H cd8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=R0ycGOlG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z26si7491027pgv.462.2019.07.12.05.29.45; Fri, 12 Jul 2019 05:30:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=R0ycGOlG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728872AbfGLM2n (ORCPT + 99 others); Fri, 12 Jul 2019 08:28:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:42664 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728831AbfGLM2e (ORCPT ); Fri, 12 Jul 2019 08:28:34 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 03950216E3; Fri, 12 Jul 2019 12:28:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562934514; bh=tfB0Yjzx+vKSU/qmFD3zv4coZikWMkBZyaZVhmcmguU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R0ycGOlGBNZENjJO883CVXq7H9v7ufRUJvxbWiqRTlcXBQuTZE7iSdM2GANnWzYdQ Ah5sVbEMMBNnk9HEQqPUBnSdlanyJAOVr162Zt/OMfaBCz/ZJl/pwHC7GJp0FkWfya R+oXZf2Uxt7wEBb9ZVcudUVI2bjMCXxp9uRKYJ58= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Matt Chen , Luca Coelho , Kalle Valo , Sasha Levin Subject: [PATCH 5.1 026/138] iwlwifi: fix AX201 killer sku loading firmware issue Date: Fri, 12 Jul 2019 14:18:10 +0200 Message-Id: <20190712121629.706800471@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190712121628.731888964@linuxfoundation.org> References: <20190712121628.731888964@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit b17dc0632a17fbfe66b34ee7c24e1cc10cfc503e ] When try to bring up the AX201 2 killer sku, we run into: [81261.392463] iwlwifi 0000:01:00.0: loaded firmware version 46.8c20f243.0 op_mode iwlmvm [81261.407407] iwlwifi 0000:01:00.0: Detected Intel(R) Dual Band Wireless AX 22000, REV=0x340 [81262.424778] iwlwifi 0000:01:00.0: Collecting data: trigger 16 fired. [81262.673359] iwlwifi 0000:01:00.0: Start IWL Error Log Dump: [81262.673365] iwlwifi 0000:01:00.0: Status: 0x00000000, count: -906373681 [81262.673368] iwlwifi 0000:01:00.0: Loaded firmware version: 46.8c20f243.0 [81262.673371] iwlwifi 0000:01:00.0: 0x507C015D | ADVANCED_SYSASSERT Fix this issue by adding 2 more cfg to avoid modifying the original cfg configuration. Signed-off-by: Matt Chen Signed-off-by: Luca Coelho Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin --- drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c index 2a03d34afa3b..80695584e406 100644 --- a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c +++ b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c @@ -3585,7 +3585,9 @@ struct iwl_trans *iwl_trans_pcie_alloc(struct pci_dev *pdev, } } else if (CSR_HW_RF_ID_TYPE_CHIP_ID(trans->hw_rf_id) == CSR_HW_RF_ID_TYPE_CHIP_ID(CSR_HW_RF_ID_TYPE_HR) && - (trans->cfg != &iwl_ax200_cfg_cc || + ((trans->cfg != &iwl_ax200_cfg_cc && + trans->cfg != &killer1650x_2ax_cfg && + trans->cfg != &killer1650w_2ax_cfg) || trans->hw_rev == CSR_HW_REV_TYPE_QNJ_B0)) { u32 hw_status; -- 2.20.1