Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Roman Kagan <rkagan@virtuozzo.com>
To:     Arnd Bergmann <arnd@arndb.de>
CC:     Paolo Bonzini <pbonzini@redhat.com>,
        =?iso-8859-2?Q?Radim_Kr=E8m=E1=F8?= <rkrcmar@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "x86@kernel.org" <x86@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Liran Alon <liran.alon@oracle.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "clang-built-linux@googlegroups.com" 
        <clang-built-linux@googlegroups.com>
Subject: Re: [PATCH] [v2] x86: kvm: avoid -Wsometimes-uninitized warning
Thread-Topic: [PATCH] [v2] x86: kvm: avoid -Wsometimes-uninitized warning
Thread-Index: AQHVOLZnDJqkDrZxKkKAHlLZPaQCbabHATaA
Date:   Fri, 12 Jul 2019 13:54:30 +0000
Message-ID: <20190712135427.GB27820@rkaganb.sw.ru>
References: <20190712133324.3934659-1-arnd@arndb.de>
In-Reply-To: <20190712133324.3934659-1-arnd@arndb.de>
Accept-Language: en-US, ru-RU
Content-Language: en-US
user-agent: Mutt/1.12.0 (2019-05-25)
mail-followup-to: =?iso-8859-2?Q?Roman_Kagan_<rkagan@virtuozzo.com>,=09Arnd_Bergmann_<arnd@?=
 =?iso-8859-2?Q?arndb.de>,_Paolo_Bonzini_<pbonzini@redhat.com>,=09Radim_Kr?=
 =?iso-8859-2?Q?=E8m=E1=F8_<rkrcmar@redhat.com>,=09Thomas_Gleixner_<tglx@l?=
 =?iso-8859-2?Q?inutronix.de>,=09Ingo_Molnar_<mingo@redhat.com>,_Borislav_?=
 =?iso-8859-2?Q?Petkov_<bp@alien8.de>,=09x86@kernel.org,_"H._Peter_Anvin"_?=
 =?iso-8859-2?Q?<hpa@zytor.com>,=09Vitaly_Kuznetsov_<vkuznets@redhat.com>,?=
 =?iso-8859-2?Q?=09Liran_Alon_<liran.alon@oracle.com>,_kvm@vger.kernel.org?=
 =?iso-8859-2?Q?,=09linux-kernel@vger.kernel.org,_clang-built-linux@google?=
 =?iso-8859-2?Q?groups.com?=
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 9a7f7a63-77aa-4ed9-8215-08d706d07676
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:PR2PR08MB4636;
x-ms-traffictypediagnostic: PR2PR08MB4636:|PR2PR08MB4636:
x-microsoft-antispam-prvs: <PR2PR08MB4636D160D4340FC19483C353C9F20@PR2PR08MB4636.eurprd08.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-forefront-prvs: 00963989E5
x-forefront-antispam-report: SFV:SPM;SFS:(10019020)(396003)(366004)(136003)(39850400004)(346002)(376002)(52314003)(189003)(199004)(26005)(6116002)(66476007)(86362001)(66446008)(64756008)(3846002)(68736007)(66946007)(486006)(54906003)(66556008)(14454004)(256004)(14444005)(36756003)(66066001)(186003)(446003)(11346002)(58126008)(476003)(316002)(7736002)(305945005)(6506007)(81166006)(81156014)(386003)(6486002)(5660300002)(6512007)(8936002)(6246003)(7416002)(8676002)(102836004)(99286004)(2906002)(53936002)(6916009)(52116002)(33656002)(25786009)(1076003)(71200400001)(71190400001)(76176011)(6436002)(229853002)(4326008)(478600001)(9686003)(30126002);DIR:OUT;SFP:1501;SCL:5;SRVR:PR2PR08MB4636;H:PR2PR08MB4649.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: virtuozzo.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: EpoJ5qYy3iE1uYT6Ijn1gwCbtWslZxLa5ZdiuWKj3TbzbHUPdC2mNqrS2iw2XgPGtJwhutvsGZ48qAJaHYbUzUZU+H8wfkHF8rEZ0oz3UoPmIq04+lEwOgQai2TOyQL4B6cJ//GuxHcW9LjIJ2kq+Z+jQ096l/SUpbJc0Rl8qS6PWIwzz+iJ3dW8ZeDRG2D3W14A4uQEUVZeGDNapd4GC2fW0BusbFw8MnCLxgoHOo5Jksl26LZsWEbbfiHsBEXycfNqKvtdJgWeOHnAR8RGXdw+6Be4fk/dEIJZC3EI7fOmp/fGsGLX43zu7fLNEqe9ZmcByuXKnOQ/lwRQlKucHmLogSkzPnyGI+/Bj41Oub2EQO8r13tGy604rBxneGVexDz3t5IyZXRDpqnkCHi3LV/yDgDs0TBcLwvDWH8lRwORYfFWfQm5HHY+qJc9GDNzOnOTOH6sNgG5WCALtz7CscaEEjKd/cJbuIIk/cv/NWamb057TtHW7YICrApw8Bhb
Content-Type: text/plain; charset="iso-8859-2"
Content-ID: <43608ADB0A8B3C49BF5F65BF0FBE848D@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: virtuozzo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a7f7a63-77aa-4ed9-8215-08d706d07676
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jul 2019 13:54:30.8355
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 0bc7f26d-0264-416e-a6fc-8352af79c58f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rkagan@virtuozzo.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4636
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 12, 2019 at 03:32:43PM +0200, Arnd Bergmann wrote:
> clang points out that running a 64-bit guest on a 32-bit host
> would lead to uninitialized variables:
>=20
> arch/x86/kvm/hyperv.c:1610:6: error: variable 'ingpa' is used uninitializ=
ed whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
>         if (!longmode) {
>             ^~~~~~~~~
> arch/x86/kvm/hyperv.c:1632:55: note: uninitialized use occurs here
>         trace_kvm_hv_hypercall(code, fast, rep_cnt, rep_idx, ingpa, outgp=
a);
>                                                              ^~~~~
> arch/x86/kvm/hyperv.c:1610:2: note: remove the 'if' if its condition is a=
lways true
>         if (!longmode) {
>         ^~~~~~~~~~~~~~~
> arch/x86/kvm/hyperv.c:1595:18: note: initialize the variable 'ingpa' to s=
ilence this warning
>         u64 param, ingpa, outgpa, ret =3D HV_STATUS_SUCCESS;
>                         ^
>                          =3D 0
> arch/x86/kvm/hyperv.c:1610:6: error: variable 'outgpa' is used uninitiali=
zed whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
> arch/x86/kvm/hyperv.c:1610:6: error: variable 'param' is used uninitializ=
ed whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
>=20
> Since that combination is not supported anyway, change the condition
> to tell the compiler how the code is actually executed.
>=20
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> v2: make the change inside of is_64_bit_mode().
> ---
>  arch/x86/kvm/hyperv.c | 6 ++----
>  arch/x86/kvm/x86.h    | 4 ++++
>  2 files changed, 6 insertions(+), 4 deletions(-)

Reviewed-by: Roman Kagan <rkagan@virtuozzo.com>

However I still think the log message could state it more explicitly
that it was the compiler's fault, and the patch is a workaround for it.

Otherwise later on someone may decide to restore the similarity of
is_64_bit_mode() to other inlines in this file, and will be extremely
unlikely to test clang 32-bit build...

Roman.