Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751126AbVLCBLq (ORCPT ); Fri, 2 Dec 2005 20:11:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751127AbVLCBLq (ORCPT ); Fri, 2 Dec 2005 20:11:46 -0500 Received: from mx1.redhat.com ([66.187.233.31]:59307 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S1751126AbVLCBLp (ORCPT ); Fri, 2 Dec 2005 20:11:45 -0500 Date: Fri, 2 Dec 2005 20:11:36 -0500 From: Dave Jones To: Zan Lynx Cc: linux-kernel@vger.kernel.org Subject: Re: Add tainting for proprietary helper modules. Message-ID: <20051203011136.GK3864@redhat.com> Mail-Followup-To: Dave Jones , Zan Lynx , linux-kernel@vger.kernel.org References: <20051203004102.GA2923@redhat.com> <1133571516.4950.8.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1133571516.4950.8.camel@localhost> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1777 Lines: 39 On Fri, Dec 02, 2005 at 05:58:36PM -0700, Zan Lynx wrote: > On Fri, 2005-12-02 at 19:41 -0500, Dave Jones wrote: > > Kernels that have had Windows drivers loaded into them are undebuggable. > > I've wasted a number of hours chasing bugs filed in Fedora bugzilla > > only to find out much later that the user had used such 'helpers', > > and their problems were unreproducable without them loaded. > > > > Acked-by: Arjan van de Ven > > Signed-off-by: Dave Jones > > > > --- linux-2.6.14/kernel/module.c~ 2005-11-29 16:44:00.000000000 -0500 > > +++ linux-2.6.14/kernel/module.c 2005-11-29 17:03:55.000000000 -0500 > > @@ -1723,6 +1723,11 @@ static struct module *load_module(void _ > > /* Set up license info based on the info section */ > > set_license(mod, get_modinfo(sechdrs, infoindex, "license")); > > > > + if (strcmp(mod->name, "ndiswrapper") == 0) > > + add_taint(TAINT_PROPRIETARY_MODULE); > > + if (strcmp(mod->name, "driverloader") == 0) > > + add_taint(TAINT_PROPRIETARY_MODULE); > > + > > #ifdef CONFIG_MODULE_UNLOAD > > /* Set up MODINFO_ATTR fields */ > > setup_modinfo(mod, sechdrs, infoindex); > > ndiswrapper adds taint already, in load_ndis_driver(). That's good to hear. Although I've definitly seen some reports which have come through untainted. My guesses are that the users were using an older ndiswrapper that didn't do this, or they were using a < 2.6.10 kernel at the time (for which ndiswrapper doesn't do this). Dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/