Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp1094967ybi; Fri, 12 Jul 2019 09:37:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqy55qJC2CGMCQ+wFX4zCEyMTrhls8zr8EMIGxQHIzZqrY/Q8bbHEiBZ7tkqq+Amo6wk3uZ/ X-Received: by 2002:a63:1645:: with SMTP id 5mr11619245pgw.175.1562949437935; Fri, 12 Jul 2019 09:37:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562949437; cv=none; d=google.com; s=arc-20160816; b=vnhBcIMduYyL9lmCieHvySTuynd5WP7jWO+INQscHUULluoKRe8wQxtLV6txMFDvnW JNJyxB/pu131ARfQOW4uP62LuQmwgtVI1z6Y9jBBMsh47MoGP5WjnvYl6JdJ3qC31Ad7 pJjve6Mh++LVQL0TqnSRiAU+vAR1GRjEQg1GTW23DcK0EQT9T7sTs9BEVJb97icLKN/4 vEgwC+g9THlAGURrf7HBCeY/6ZBi71WdyWfZuKGABF/dWNE+45D6xROOEbnxscS2xKJY b/ye5UASwyDzGciCUnfp45iu/wyfVolwC70+W6YKs64UKuNKogR6gYk/m4zmRKcdIrsy BAXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=rf/TIgr/HRkl2+DUXrcR8il8lDtn6SxtRXCIZ10lp4g=; b=u0CSPbeawed41UBgO5phWHESOHlbPYFrUqoXQfZEOJQF+yGrAJUkT0BwW9Gutc7u8G 6bmB57s4oOZ5cv2zcZpVuVcsEBtZLRNf63dTcuVnFCt2B3dbH3ZlGjICrFBhMUMIuiv7 CRSqYpXkinWIw6S3Sn6BA2KIWob2ONidiCI7eVfrz2sEPPq74t28ahfwZ3GDzVOkdbN0 eymynO10iZWiTnDTrWa50imf470TNiq2x1fzj4Cq66OJv2MZEqWgqgJvkUFxmxPtj0dj uASP6BWU6i0XrbvxDV7v3Ekzk+lFePV347u12uc5VRNSQ4ytLBLTYVCjI4NPpp2P2li7 Ge0g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g18si8388693plq.190.2019.07.12.09.37.02; Fri, 12 Jul 2019 09:37:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727229AbfGLQg2 (ORCPT + 99 others); Fri, 12 Jul 2019 12:36:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60258 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726449AbfGLQg2 (ORCPT ); Fri, 12 Jul 2019 12:36:28 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4E5CE88E55; Fri, 12 Jul 2019 16:36:28 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.43.17.136]) by smtp.corp.redhat.com (Postfix) with SMTP id 2F4BD600CD; Fri, 12 Jul 2019 16:36:27 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Fri, 12 Jul 2019 18:36:28 +0200 (CEST) Date: Fri, 12 Jul 2019 18:36:26 +0200 From: Oleg Nesterov To: Alexey Izbyshev Cc: Alexey Dobriyan , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, security@kernel.org Subject: Re: [PATCH] proc: Fix uninitialized byte read in get_mm_cmdline() Message-ID: <20190712163625.GF21989@redhat.com> References: <20190712160913.17727-1-izbyshev@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190712160913.17727-1-izbyshev@ispras.ru> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 12 Jul 2019 16:36:28 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/12, Alexey Izbyshev wrote: > > --- a/fs/proc/base.c > +++ b/fs/proc/base.c > @@ -275,6 +275,8 @@ static ssize_t get_mm_cmdline(struct mm_struct *mm, char __user *buf, > if (got <= offset) > break; > got -= offset; > + if (got < size) > + size = got; Acked-by: Oleg Nesterov