Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp1117567ybi; Fri, 12 Jul 2019 10:01:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqyz5b1YhQfqf7lvI8e4jHgoSkrQb9DNMnqTUakmFfc0ajqnHxaP1XVrKtCeWYHlUMToQZd8 X-Received: by 2002:a17:902:20c8:: with SMTP id v8mr12676044plg.284.1562950913821; Fri, 12 Jul 2019 10:01:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562950913; cv=none; d=google.com; s=arc-20160816; b=XjwIZ3Ax1fJyrjjGtYDP0UzFs8wPunVx+GhzSld4bJ25oZUx+k7DLdMXCtum0syFdI Lplk1/ac/cn7AdbSnejEAk3OVgHoZHTvn0jjIF0q7MWOsFynERNK5mzAUY4Tz6xVXAbw KVCNwzI4WslUsqKQEeXqFZA4+MnBJ9D+lT2DIZrNpostZ8x3ncs5qGmEdY9FwfK4/2cG 7UMVwXKpYuznNtHlwYU+exyG4KJvAoUTtkSMylHq+r6wuV/0seFKV9ipbV1ooZwQ3hOd Ry4ljJG6vnchgWHIh7Ffp7t6HFNPLFAetGXuhO2dlQ6PQrpwFlboVTlPnOrKuSs+s9At 91xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=T5MSBvyW+UnMIf1PMXwWQpclTkJPOBVtLcNCxIfokXY=; b=TolU7xSZ1sW1VYtNyuCfUCwNjVCWyNhvMwOj/hd8sK8gT/6q6/S4DoC5WwJGbRu1S9 A+vTm895f3vhFFyKSV3ESFZ1h3avOPyNv5vsubyn/GHtBaD+2R0WdbirZgQKbFNkl7yf NQaM830C6yhRkXby+91mZEdZqk4x1PDvkBDUdemdZCbhAey2nYdazqMllTankVymB32h ICLNw73UQhq8OjCEGQL76kWBgjJmIDyp/UYIFRvzAgvWPHbL6YzWz3q8CJPwTf02ZHip +ZisFfXLMFm+iBozYF82V3cqaf9eufb2TMPyG0YJWvpvFQ5fndl5n1IU/t/WVJqW4/Mq AYEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=W4pcI9yz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g90si8212017plb.282.2019.07.12.10.01.38; Fri, 12 Jul 2019 10:01:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=W4pcI9yz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727508AbfGLRAz (ORCPT + 99 others); Fri, 12 Jul 2019 13:00:55 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:43795 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727488AbfGLRAv (ORCPT ); Fri, 12 Jul 2019 13:00:51 -0400 Received: by mail-pf1-f196.google.com with SMTP id i189so4552648pfg.10 for ; Fri, 12 Jul 2019 10:00:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=T5MSBvyW+UnMIf1PMXwWQpclTkJPOBVtLcNCxIfokXY=; b=W4pcI9yzebCS/ajeXGrdH4WDZbUsJndTMc7qtATG156f3ffkoMMnM+27/wia2nKDJk 8+5mV67a7LLoP3HBFS64qyErr1wWta5bAaSdftnGrTPpiVb4PMfGdj4gRSASKJrtE/bk y6MZeHXSPOQSGLoKr4GkENL9AUyzztzIy9lqM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=T5MSBvyW+UnMIf1PMXwWQpclTkJPOBVtLcNCxIfokXY=; b=D8KL+mPSwobl+JVr4TZOsjwMfMnUb38Lxn2jEkK+Am3ZSt2FQ7yXBx5AzRo1L6+O35 Q4wiSJnmSkhQePBBPrSTprdOtj1VQtd4iQDq4TKM/bkpTVDkBkuJof/hhgHpyhaAJ0nW glz03zP2nViNbgzJYOVDOQKtnj/HEJTybJbXWfTvYrKbd8eqUROFUlZ+GumLPJVW5e21 Ot/4zxfRJfx0ck8XZlcWZWzrnIpT4Tp7nb2ztSGYS67OWXKCObneul3bh+50tY0FLq0k Ex+c3wxY8EarhdAyQ9fAQRihwZvLU3GC+yqGr5c23/L4m4z2BDcDFBGPle4gu/Iy6XBk AAbA== X-Gm-Message-State: APjAAAVIyQVPOX2z18wfKmJVLyEkUAOOuF2YDTDe5+sdhqa01n+foLYT HALY9lKnCQzRbN3SxQKQ0TsFbhIA X-Received: by 2002:a65:4489:: with SMTP id l9mr12246140pgq.207.1562950850333; Fri, 12 Jul 2019 10:00:50 -0700 (PDT) Received: from joelaf.cam.corp.google.com ([2620:15c:6:12:9c46:e0da:efbf:69cc]) by smtp.gmail.com with ESMTPSA id a15sm7127385pgw.3.2019.07.12.10.00.46 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 12 Jul 2019 10:00:49 -0700 (PDT) From: "Joel Fernandes (Google)" To: linux-kernel@vger.kernel.org Cc: "Joel Fernandes (Google)" , Alexey Kuznetsov , Bjorn Helgaas , Borislav Petkov , c0d1n61at3@gmail.com, "David S. Miller" , edumazet@google.com, Greg Kroah-Hartman , Hideaki YOSHIFUJI , "H. Peter Anvin" , Ingo Molnar , Jonathan Corbet , Josh Triplett , keescook@chromium.org, kernel-hardening@lists.openwall.com, kernel-team@android.com, Lai Jiangshan , Len Brown , linux-acpi@vger.kernel.org, linux-doc@vger.kernel.org, linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, Mathieu Desnoyers , neilb@suse.com, netdev@vger.kernel.org, Oleg Nesterov , "Paul E. McKenney" , Pavel Machek , peterz@infradead.org, "Rafael J. Wysocki" , Rasmus Villemoes , rcu@vger.kernel.org, Steven Rostedt , Tejun Heo , Thomas Gleixner , will@kernel.org, x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)) Subject: [PATCH v2 4/9] ipv4: add lockdep condition to fix for_each_entry Date: Fri, 12 Jul 2019 13:00:19 -0400 Message-Id: <20190712170024.111093-5-joel@joelfernandes.org> X-Mailer: git-send-email 2.22.0.510.g264f2c817a-goog In-Reply-To: <20190712170024.111093-1-joel@joelfernandes.org> References: <20190712170024.111093-1-joel@joelfernandes.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Signed-off-by: Joel Fernandes (Google) --- net/ipv4/fib_frontend.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c index b298255f6fdb..ef7c9f8e8682 100644 --- a/net/ipv4/fib_frontend.c +++ b/net/ipv4/fib_frontend.c @@ -127,7 +127,8 @@ struct fib_table *fib_get_table(struct net *net, u32 id) h = id & (FIB_TABLE_HASHSZ - 1); head = &net->ipv4.fib_table_hash[h]; - hlist_for_each_entry_rcu(tb, head, tb_hlist) { + hlist_for_each_entry_rcu(tb, head, tb_hlist, + lockdep_rtnl_is_held()) { if (tb->tb_id == id) return tb; } -- 2.22.0.510.g264f2c817a-goog