Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751151AbVLCCDo (ORCPT ); Fri, 2 Dec 2005 21:03:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751152AbVLCCDo (ORCPT ); Fri, 2 Dec 2005 21:03:44 -0500 Received: from mail-in-09.arcor-online.net ([151.189.21.49]:5521 "EHLO mail-in-09.arcor-online.net") by vger.kernel.org with ESMTP id S1751151AbVLCCDo (ORCPT ); Fri, 2 Dec 2005 21:03:44 -0500 From: Bodo Eggert Subject: Re: [PATCH 0/4] linux-2.6-block: deactivating pagecache for benchmarks To: Andrew Morton , Dirk Henning Gerdes , axboe@suse.de, linux-kernel@vger.kernel.org Reply-To: 7eggert@gmx.de Date: Sat, 03 Dec 2005 03:05:34 +0100 References: <5f08L-Um-413@gated-at.bofh.it> <5f7UE-3FH-13@gated-at.bofh.it> User-Agent: KNode/0.7.2 MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8Bit Message-Id: X-be10.7eggert.dyndns.org-MailScanner-Information: See www.mailscanner.info for information X-be10.7eggert.dyndns.org-MailScanner: Found to be clean X-be10.7eggert.dyndns.org-MailScanner-From: harvested.in.lkml@posting.7eggert.dyndns.org Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 850 Lines: 18 Andrew Morton wrote: > + .procname = "drop-pagecache", > + .data = NULL, > + .maxlen = sizeof(int), > + .mode = 0644, 1) Shouldn't this be a trigger? Reading from a trigger doesn't make sense, especially when triggering on a read. .mode = 0200? 2) If you pass an int, wouldn't a bitmask selecting what to free make sense? (off cause -1 == everything) Maybe this would be overengineered. -- Ich danke GMX daf?r, die Verwendung meiner Adressen mittels per SPF verbreiteten L?gen zu sabotieren. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/