Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp2108220ybi; Sat, 13 Jul 2019 07:00:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqzNZMX0K73L5nRq/VD2YfAwnbEpJ6DHqTwKikBAr5Sjw+OkmtEEFskCA4LcS7eSi3buDkt+ X-Received: by 2002:a17:902:4643:: with SMTP id o61mr17694556pld.101.1563026438667; Sat, 13 Jul 2019 07:00:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563026438; cv=none; d=google.com; s=arc-20160816; b=vcxzV+Hqa0ljPuBx+8OiWL99xsDbHDL3mct7fE7f7/5P6fPKmx98m4dXAJBb2mRln8 Air0zGRLKdRKX0ACo3TrZuP/uTdArb/NsjOq6MRlkSTp5dVMqStg6ADpFF/k1QGcwLEZ ATCRQHl+KFPux7Cp6KMISchN5/b8YnGF+Zk2VFs0/LNRJYyhGuGWVAzMDiRTNnD3VeL/ X0g01PB7EWeN5HBbGTUsFrVkk7gyK4r54Ye2FPgJ/rUJWZV8O8FFwZWKT4WcRStYg9WS U2ylcjDo352EXRuz8ugFec2NwT4EQ72eIFzQnSST0pHsgzSAhK9ebwZHiSehHM2Ep5Vd lsOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=WiBaGQ8jNgrR2L3Ku+ETnzExBi4wcqGaxkud7n89S1U=; b=NwG2uXQNpu9t8SXxA8yv4+2G9ClEea3NicLqv+sl/AYIfP8s/0YwuGQ8OE4QIpB/Sj ceuJlULUB4no54ReJr9ODLfElakk2yhWNK76TR5Ea6XBy1lWlTYg2xzPWr0pw2ztEWKw gpMjVNrqfV4l64RHeU1MZkkYYggr74tTdGFEbPMoGuiiz9PA3DO2bctNBq1jQwK0CiPO ikHyRBhyo21aCo2a6BK37968ecF5OiJBsik466JprHAv3ISxZ+BeUexGgYovVuLemWbs /Yk0oVsd3lB3L69xzV0mXkVUga2EDKL5ZK4w+4N/YTAsGqeI4Ybx/VoY/M9L0fYS7Msf IMUA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k16si11204667pfi.174.2019.07.13.07.00.22; Sat, 13 Jul 2019 07:00:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727696AbfGMOAF (ORCPT + 99 others); Sat, 13 Jul 2019 10:00:05 -0400 Received: from bran.ispras.ru ([83.149.199.196]:27345 "EHLO smtp.ispras.ru" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727504AbfGMOAF (ORCPT ); Sat, 13 Jul 2019 10:00:05 -0400 Received: from [10.10.3.112] (starling.intra.ispras.ru [10.10.3.112]) by smtp.ispras.ru (Postfix) with ESMTP id 91207201D0; Sat, 13 Jul 2019 17:00:02 +0300 (MSK) Subject: Re: [PATCH] proc: revert /proc/*/cmdline rewrite To: Alexey Dobriyan , akpm@linux-foundation.org Cc: oleg@redhat.com, mkubecek@suse.cz, torvalds@linux-foundation.org, shasta@toxcorp.com, linux-kernel@vger.kernel.org, security@kernel.org References: <20190713072855.GB23167@avx2> <20190713073209.GC23167@avx2> From: Alexey Izbyshev Message-ID: <5a5e6914-6450-319d-0d57-5098913ad47c@ispras.ru> Date: Sat, 13 Jul 2019 17:00:02 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: <20190713073209.GC23167@avx2> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/13/19 10:32 AM, Alexey Dobriyan wrote: > /proc/*/cmdline continues to cause problems: > > https://lkml.org/lkml/2019/4/5/825 > Subject get_mm_cmdline and userspace (Perl) changing argv0 > > https://marc.info/?l=linux-kernel&m=156294831308786&w=4 > [PATCH] proc: Fix uninitialized byte read in get_mm_cmdline() > > This patch reverts implementation to the last known good state. I confirm that this revert fixes both issues above on my system (x86_64). Alexey