Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Keyur Patel <iamkeyur96@gmail.com>
Cc:     markus.elfring@web.de, Keyur Patel <iamkeyur96@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Christian Gromm <christian.gromm@microchip.com>,
        Suresh Udipi <sudipi@jp.adit-jv.com>,
        Colin Ian King <colin.king@canonical.com>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH v4] staging: most: remove redundant print statement when
 kfifo_alloc fails
Date:   Sun, 14 Jul 2019 11:05:43 -0400
Message-Id: <20190714150546.31836-1-iamkeyur96@gmail.com>
In-Reply-To: <20190711175055.25157-1-iamkeyur96@gmail.com>
References: <20190711175055.25157-1-iamkeyur96@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
To:     unlisted-recipients:; (no To-header on input)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

This print statement is redundant as kfifo_alloc just calls kmalloc_array=0D
without the __GFP_NOWARN flag, already does a dump_stack().=0D
=0D
Signed-off-by: Keyur Patel <iamkeyur96@gmail.com>=0D
---=0D
Changes in v3:=0D
- fix checkpatch warning=0D
=0D
 drivers/staging/most/cdev/cdev.c | 4 +---=0D
 1 file changed, 1 insertion(+), 3 deletions(-)=0D
=0D
diff --git a/drivers/staging/most/cdev/cdev.c b/drivers/staging/most/cdev/c=
dev.c=0D
index d0cc0b746107..724d098aeef0 100644=0D
--- a/drivers/staging/most/cdev/cdev.c=0D
+++ b/drivers/staging/most/cdev/cdev.c=0D
@@ -463,10 +463,8 @@ static int comp_probe(struct most_interface *iface, in=
t channel_id,=0D
 	spin_lock_init(&c->unlink);=0D
 	INIT_KFIFO(c->fifo);=0D
 	retval =3D kfifo_alloc(&c->fifo, cfg->num_buffers, GFP_KERNEL);=0D
-	if (retval) {=0D
-		pr_info("failed to alloc channel kfifo");=0D
+	if (retval)=0D
 		goto err_del_cdev_and_free_channel;=0D
-	}=0D
 	init_waitqueue_head(&c->wq);=0D
 	mutex_init(&c->io_mutex);=0D
 	spin_lock_irqsave(&ch_list_lock, cl_flags);=0D
-- =0D
2.22.0=0D
=0D