Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 14 Jul 2019 16:09:08 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Wolfram Sang <wsa@the-dreams.de>
Cc:     Marek Vasut <marek.vasut@gmail.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Arnd Bergmann <arnd@arndb.de>, stable <stable@vger.kernel.org>,
        Marek Vasut <marek.vasut+renesas@gmail.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Simon Horman <horms+renesas@verge.net.au>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Rob Herring <robh@kernel.org>,
        Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
        linux-iio@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: adc: gyroadc: fix uninitialized return code
Message-ID: <20190714160908.7443eca6@archlinux>
In-Reply-To: <20190704195557.GA1338@kunai>
References: <20190704113800.3299636-1-arnd@arndb.de>
        <20190704120756.GA1582@kunai>
        <CAMuHMdXDN60WWFerok1h05COdNNPZTMDCgKXejmQZMj9B6y5Cw@mail.gmail.com>
        <fc3b8b4e-fe0e-9573-124d-4b41efa409e4@gmail.com>
        <20190704195557.GA1338@kunai>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 4 Jul 2019 21:55:58 +0200
Wolfram Sang <wsa@the-dreams.de> wrote:

> > >> This is correct but missing that the above 'return ret' is broken, too.
> > >> ret is initialized but 0 in that case.  
> > > 
> > > Nice catch! Oh well, given enough eyeballs, ...  
> > 
> > I don't think ret is initialized, reg is, not ret .  
> 
> It is initialized for the broken 'return ret' *above* the one which gets
> rightfully fixed in this patch.
> 

Agreed, 2 broken cases and this is only fixing the second one.
I'm expecting a v2 of this patch which fixes them both, so 
won't apply this v1.

Thanks,

Jonathan