Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp3246526ybi; Sun, 14 Jul 2019 09:43:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqxPUxR34S3D7vnzpmjMvlOspZU7PgqibbdhQWaWxTMYYDdD24KbZemLD3TuKY45tPXim3Yn X-Received: by 2002:a17:902:6ac6:: with SMTP id i6mr23745871plt.233.1563122591827; Sun, 14 Jul 2019 09:43:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563122591; cv=none; d=google.com; s=arc-20160816; b=DgOYE+tjS4B0cDtyTAEH5XNKecvwI6fkuafYUnp8LR2oTSRlHfHujmHO3/k64DxaEh m6LzTHQPkXcqEuHNY4HEn0h363fHv5fsRHFsL+EHYo6oKAqXGBP9nAxdL/5UoylWwz8n 79j3/LCTZYsSnfUerEWGCLrb2zncSpGSpIkzMIsN0jpyfTlZL9TCRecTm7vMdkl87q9V aJf92f+vaqIX12q9YcGqX3LciVWyQtGhfivxjZplP8eaajGH3ais708IQQsZ4VqyYA8P jlLhIWAHS02/H3jfeyfCtuGGqMxp7Ud/H9XY3TWMu0c45LsDl8XJ61yYmn/mvERd9YA2 5FPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:from :dkim-signature; bh=17NxJyOTQqneQKqILFL+Kfh800SL9vsxcwn5ys2+a/0=; b=E4fbV4SbInhMICR7zSqW7Yuk16v6oOd22IWOTwSj5TeNHP1Ebbpztkh/jVYtN7o6H8 E4/AcAnrjvt4lsVeNZ+AMjN/h2ULfzJrfqJJI/dqHQqtRfygSVE+vyhV8A3H7AWHgEND vxWrbL7AaGae8O2/0pPDBSALwhLcEmJAexn7gsagP1u/Hpg2d6hoFa9WzJn6l7/X5s9+ 0BSOPjdFsDFqokO/HfwkqocUkyNslfsClfxMqE5/jaPaX2LAkniVHZmit/0hoek+b0LL csjRIILcCjMR9SlLPpQkKlPi5/6JTKt8algLk1g/VUeHW0YAk7HHgOdI2Y2d7PrquGFn IbcA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="azYm/S4F"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h4si14604702pgf.171.2019.07.14.09.42.53; Sun, 14 Jul 2019 09:43:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="azYm/S4F"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728624AbfGNQmE (ORCPT + 99 others); Sun, 14 Jul 2019 12:42:04 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:42291 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728065AbfGNQmD (ORCPT ); Sun, 14 Jul 2019 12:42:03 -0400 Received: by mail-qt1-f194.google.com with SMTP id h18so13269128qtm.9 for ; Sun, 14 Jul 2019 09:42:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=17NxJyOTQqneQKqILFL+Kfh800SL9vsxcwn5ys2+a/0=; b=azYm/S4FEqrQmVAbcBXUA6zpmF8+qsRMlb0Iw/3XhUBI11liAps/povLyoAK4mhhAO AYQcFmhCNtupDtAkM8O1WAPqT0Bc+Jqzmk3MT7a1+ZnQCvj9xY2JMvBs38Yhh+XOzzGf S32xdtCs1ZtfnwVGeXmzX+GOUIt4+4jN5O/Poo2fMrrJpoDg31kaKvA4C7JoMFycAYRO PpiA+gp/vyXUIoZ3Mr5wYktb3ROFHzUa6df8XB8hm+KYiXFXCdJAFLQqWrFCU1FzM1en 6KY9Jc/K4Vsu4C1pe9/8vaWB9UiiFF0rmekTWiKb7TAtx5DNGHtSHeDIVurmpR8OpAmk INig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=17NxJyOTQqneQKqILFL+Kfh800SL9vsxcwn5ys2+a/0=; b=rmh601o88lcWIYRbh4yjBxyTF/e7qLSjO+Aj4G/JUb9yrsGbsotTh9/Wr9P5ji7Omp hmRIO7k68xW5ccK6afZUtDKgi8eVc6ovnUz4KuQne2hUCfbohyQEoGlm4XER4NY3Y1zf 7gtC8kIXXu5ESBVLg+4F+jPQVk2BTZDTGdb1NQytGAyoNkb7q9F8VM8fZ18aMmDyMUnZ IsRLk4+6tuGYabrBL7ModEVb4MO2rKeMKoEyho5kbKejSbyMBShiICxGjWL+JqfWl/00 g8aR/DPMwsrUMnMgrA68llDsqaNdhu0iQvf+W+Z63dFLV6HsabKA4DrdHdZnnw81ldOt jnlA== X-Gm-Message-State: APjAAAUgE4EO6jF6HteubT3JU/5O4Ik6mAou0AkIEJFjnyCHSO7ji4gb popgd8MZ9OjOodwIlCvTXg== X-Received: by 2002:ac8:2bdc:: with SMTP id n28mr14811226qtn.197.1563122522773; Sun, 14 Jul 2019 09:42:02 -0700 (PDT) Received: from localhost.localdomain (modemcable148.230-83-70.mc.videotron.ca. [70.83.230.148]) by smtp.googlemail.com with ESMTPSA id h18sm5704034qkk.93.2019.07.14.09.42.01 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sun, 14 Jul 2019 09:42:02 -0700 (PDT) From: Keyur Patel Cc: markus.elfring@web.de, Keyur Patel , Greg Kroah-Hartman , Christian Gromm , Eugeniu Rosca , Suresh Udipi , Colin Ian King , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH v4] staging: most: Delete an error message for a failed memory allocation Date: Sun, 14 Jul 2019 12:41:23 -0400 Message-Id: <20190714164126.3159-1-iamkeyur96@gmail.com> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190711175055.25157-1-iamkeyur96@gmail.com> References: <20190711175055.25157-1-iamkeyur96@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This error message for a failed memory allocation is redundant as kfifo_alloc just calls kmalloc_array without the __GFP_NOWARN flag, already does a dump_stack(). Signed-off-by: Keyur Patel --- Changes in v4: - change subject line - improve commit description - fix checkpatch warning drivers/staging/most/cdev/cdev.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/most/cdev/cdev.c b/drivers/staging/most/cdev/cdev.c index d0cc0b746107..724d098aeef0 100644 --- a/drivers/staging/most/cdev/cdev.c +++ b/drivers/staging/most/cdev/cdev.c @@ -463,10 +463,8 @@ static int comp_probe(struct most_interface *iface, int channel_id, spin_lock_init(&c->unlink); INIT_KFIFO(c->fifo); retval = kfifo_alloc(&c->fifo, cfg->num_buffers, GFP_KERNEL); - if (retval) { - pr_info("failed to alloc channel kfifo"); + if (retval) goto err_del_cdev_and_free_channel; - } init_waitqueue_head(&c->wq); mutex_init(&c->io_mutex); spin_lock_irqsave(&ch_list_lock, cl_flags); -- 2.22.0