Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 14 Jul 2019 13:57:59 -0400
From:   Joel Fernandes <joel@joelfernandes.org>
To:     Jiri Olsa <jolsa@redhat.com>
Cc:     linux-kernel@vger.kernel.org, acme@kernel.org,
        Jiri Olsa <jolsa@kernel.org>
Subject: Re: [RFC] Fix python feature detection
Message-ID: <20190714175759.GA34501@google.com>
References: <20190707144417.237913-1-joel@joelfernandes.org>
 <20190714154006.GB16802@krava>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190714154006.GB16802@krava>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Jul 14, 2019 at 05:40:06PM +0200, Jiri Olsa wrote:
> On Sun, Jul 07, 2019 at 10:44:17AM -0400, Joel Fernandes (Google) wrote:
> > I am having a hard time building BPF samples by doing a make in
> > samples/bpf. While I am debugging that, I ran into the Python issue.
> > Even though the system has libpython2.7-dev:
> > 
> > If I just do a 'make' inside tools/build/feature/ I get:
> > Python.h: No such file or directory
> 
> because you don't have FLAGS_PYTHON_EMBED set?
> 
> > 
> > This led me to this patch which fixes Python feature detection for me.
> > I am not sure if it is the right fix for Python since it is hardcoded
> > for Python version 2, but I thought it could be useful.
> 
> we detect python in tools/perf/Makefile.config and
> set FLAGS_PYTHON_EMBED properly
> 
> it's supposed to be set by a project using tools/build
> for feature detection.. what are you building? AFAICS
> samples/bpf do not use tools/build

Yes, you are right. Never mind then. I was debugging feature detection and
ended doing a make in this directory like:

make <something>.bin which works always except for python. But as you said it
is likely a non-issue.

thanks!

 - Joel