Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp3698966ybi; Sun, 14 Jul 2019 20:20:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqxOZVnLSR94FjNdQXIcLlkoP4HJBXL1PFL16FbNYDAK5lcb/3yiyRPEfispByG/BhVt1f+e X-Received: by 2002:a65:5cca:: with SMTP id b10mr25119184pgt.365.1563160837858; Sun, 14 Jul 2019 20:20:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563160837; cv=none; d=google.com; s=arc-20160816; b=SWEoTwRNiPGyzJQYe+eNyy+fhabiNMCW45XDZ7k+Q0MbNr4KySC+43CK7rUXjD6E8B 9sb4SvQC7VnI2B3r8SwqNh9joMUAUJLtvl34icC4Pylc188s4T8MXYKq6usk93QwIFl1 FP4z+rQRRXMMQaJbJv6U2Q9Y+k4ZJnpmAs0qfOKWdzOzeC56iCdgDkcnHUg49ZKQGw0Z SP3NQWb8p6BlUfZginIzjtRKiLSaimHNsyzhhPR38t45sU0Zph7ckkvB2jKzm+o5/T2/ tYV+PFmgMoCAz88q0wJRwX9wmaQt49GGSLop6DL/FxcVPdlCpC78C9YFkOJwxOQ6x9Dq QBnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:message-id:date:subject:cc:from :dkim-signature; bh=rAUMXzHwviit3EWOrZi2p+vSW9wN4kYz9UnlLQwtU3g=; b=Yjib9gWVo7muXNZUv+hHQKN1VlzATZuamKPBLKtNwcsntsR71W+GR82GVs9wylQybV D+Obky84KYdan7yTiTJ1XkjrsQKbWIpBOB528iZcCrdhrxdixVJ6l/B8S2C2w5xuDQKB vI+/d5WgPgzaUcY5bkWP+riBun8eoMdK82iNzFEzWBh0ZdV7VyylgnHcIFRdVtCZJcjf 9jpU9DDCgeygSPLvkfWxcDwaP16OF4E/QGWPbrRdT1s2+fUUD0JR0MMgXkugjd0jUmzB 9MHrnbaYG4ebPFtOgc8J5upPi50jKHWyNmZUdZyHLqA9vQZZpXmlx+zVpfFZPOPeEKQM VjmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=uznpD+Zy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s24si4994573pgq.372.2019.07.14.20.20.22; Sun, 14 Jul 2019 20:20:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=uznpD+Zy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729213AbfGODSW (ORCPT + 99 others); Sun, 14 Jul 2019 23:18:22 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:34444 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728999AbfGODSW (ORCPT ); Sun, 14 Jul 2019 23:18:22 -0400 Received: by mail-pg1-f194.google.com with SMTP id n9so778009pgc.1; Sun, 14 Jul 2019 20:18:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=rAUMXzHwviit3EWOrZi2p+vSW9wN4kYz9UnlLQwtU3g=; b=uznpD+ZyqkFc2z3C4topCy403sbzlzEdtqDizLvP0EEvUhnO/INmCYnPl6+Dv0APNM CH3KDp77QkPPIHIV+1Ci4a3AUzaQ99xp1ev6aSd5XE1UydzpTBSuOmQODPRlcCnNMbzP vhwNIZT33HYj/XqwDtLQBVs9s1OnFyEbgT+f10ujcgzFMGHq8ylzRbSqeHrY1h+RHeGP 3G4eKpWLBafPpNLDU7AtAdu70LYqK30ght9Mxq7QTy3JuVUgaM9ThsJdOdwmfZjgIg6t GeiRdGeH4JfTEHxaVe+VRm85M5C8lpbqkSU78Z7obPxx8gvAtVfdFiOU2LitTxO4h0ON tENg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=rAUMXzHwviit3EWOrZi2p+vSW9wN4kYz9UnlLQwtU3g=; b=P1e/8/ACOJOZM8UX/MfJ/2eGgvpk9UMXMrMfM97eKQy4B7b2GVdsuRF5MEXXxizOQ6 0ZnjvPHglcoOc0BQGeZ560uxgaHtiDAbo1HEsSb/ZWj9w1jefmJZ/s+7qvCa6ofzAg54 q83UUg45QnNqhljsDLi7mwwwjyfGVdWK71Hngp/WXKn+JmIzZenPdoc/PTVstDb5ttpX ItVKvaysBj8nFIGw1Nyq5M+pf3tH76kbt7At+l/0/VnZhIzBWKOsKYRTZADW1BbP6trG qFFKZK6B+Ze6VuiGWksvhWRXBNsuyZRIv8PJ643D2Epi6HPLqQ0uvttJnKHn4wuik1Fr J/vw== X-Gm-Message-State: APjAAAV2z7VnCFavG0ww87ruupiHnTabLRbDkgZ+zA2D7Cjv24UlDhda NOgQ9Na/yk9psb+vZxrsNJYwkywvmiE= X-Received: by 2002:a17:90a:37ac:: with SMTP id v41mr25623284pjb.6.1563160701890; Sun, 14 Jul 2019 20:18:21 -0700 (PDT) Received: from hfq-skylake.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.googlemail.com with ESMTPSA id f14sm14662328pfn.53.2019.07.14.20.18.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 14 Jul 2019 20:18:21 -0700 (PDT) From: Fuqian Huang Cc: Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Fuqian Huang Subject: [PATCH v3 10/24] IB/mthca: Remove call to memset after dma_alloc_coherent Date: Mon, 15 Jul 2019 11:18:16 +0800 Message-Id: <20190715031816.6657-1-huangfq.daxian@gmail.com> X-Mailer: git-send-email 2.11.0 To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In commit 518a2f1925c3 ("dma-mapping: zero memory returned from dma_alloc_*"), dma_alloc_coherent has already zeroed the memory. So memset is not needed. Signed-off-by: Fuqian Huang --- Changes in v3: - Use actual commit rather than the merge commit in the commit message drivers/infiniband/hw/mthca/mthca_allocator.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/infiniband/hw/mthca/mthca_allocator.c b/drivers/infiniband/hw/mthca/mthca_allocator.c index aaf10dd5364d..aef1d274a14e 100644 --- a/drivers/infiniband/hw/mthca/mthca_allocator.c +++ b/drivers/infiniband/hw/mthca/mthca_allocator.c @@ -214,8 +214,6 @@ int mthca_buf_alloc(struct mthca_dev *dev, int size, int max_direct, dma_unmap_addr_set(&buf->direct, mapping, t); - memset(buf->direct.buf, 0, size); - while (t & ((1 << shift) - 1)) { --shift; npages *= 2; -- 2.11.0