Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp3700704ybi; Sun, 14 Jul 2019 20:22:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqxXZdxqE/Ucjbx1t2hh97mJb10sMhoLMdyOhWp8w3SVDILCHkq4YWIG3fYnHCHcqJZZguFC X-Received: by 2002:a17:902:5a2:: with SMTP id f31mr25597457plf.72.1563160972528; Sun, 14 Jul 2019 20:22:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563160972; cv=none; d=google.com; s=arc-20160816; b=cuZ7JfDg+PZu3IpfruVKN4RV9ffnCvIkC0/scZjEX0Ox1KtmJ1Hl0WvQh9dj2k4ocS +OfdsbzrW98g3ohMie/VlvaOotMHVB41ZI38wue8rK7In3lCg7HXbdVpaU+Bt1V9IvSn ZBTPF+fgTLUo26TJcSFZlts0xcoVXjc1DgGHqrYfZ8bTQxiueu3yQw2yZPvHQNi312Mv z2JsJeQSo+eQk9AygzjcpWkPISWYOSQJv0bfhoJIMQd13m8fowKfclHvdEPhKCxW5+JB 470i7YxD9koKZc8gRrJST5RuHG7w9gbugH0zd99Y/fHSrpx2RRXDyV67oSSckp/xDzDJ 0sGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:message-id:date:subject:cc:from :dkim-signature; bh=x9cx5daqiIQ1tM3rWp5IoFUTEpi0lqApKNh4MFAdUvE=; b=hIJHLl55Sg01KZcNJ2WjZMtQV7u31MPH2K7miFr++FV5pr2Rm0LGnVnsHwHYbRUI+Z WFjHjU/Qf6tVpHxCuHpCZdoT8YREaR2F8rHepjQRIkJ1u5LcRjSQWoe74xhHSW0Bd2YR xjoRJtm23bedbrKvZc9Vb7TXfFel1EA21b7eqcbGcmeTIgr3mVQfilYRAu5ZT/oMciyc Qh/V4xdFbSGKW7KBt4S0mAF+yzKjBZKV/U8hY2R08iInUtI+kmu2fTq0uHRMU3qOuZuD BTb+LPIlqLeXPTGifyxPahkLj4A/oKtRkWX7KYnFAH68FjyzInqJm81eJX5KO3YKALgE rlLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=YrK9lUHA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q19si15333123pgg.521.2019.07.14.20.22.36; Sun, 14 Jul 2019 20:22:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=YrK9lUHA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729367AbfGODUI (ORCPT + 99 others); Sun, 14 Jul 2019 23:20:08 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:36192 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727006AbfGODUI (ORCPT ); Sun, 14 Jul 2019 23:20:08 -0400 Received: by mail-pg1-f193.google.com with SMTP id l21so7005477pgm.3; Sun, 14 Jul 2019 20:20:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=x9cx5daqiIQ1tM3rWp5IoFUTEpi0lqApKNh4MFAdUvE=; b=YrK9lUHAxSclec2PcYrOeb8GCIzvTz83nYqWGUZVOEURLw26zIPDvWcqMaeCNLIcNX ERI9NjxPCZqB1wDWWOY2dImu60zpk3CSXHLwccOoGN+45M5uI321JfDrG1llWg6K3FtF HLsv/+vg8ECHgCLk8uxkYuMv4mm5c8LBz8W1nxTzkJ0M/orfsEXOd/EXIYEVLjhDKdC6 0Wx4CjW2UzUSlBSxeJI0hTP1zZCc9ABYSTzfZ6FoyQrnuZIlroaIEPvCUZjZkAGfCMym ZA5rSHiausMHGmfdYkpnDHxUMCD7uVcC4LPGCQljs/+xDwD/65bou0ptIIj5wW1THX78 9eEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=x9cx5daqiIQ1tM3rWp5IoFUTEpi0lqApKNh4MFAdUvE=; b=cCDJ0uQnE1Nswlob6w9XNXsALEFdl4g3fCKOv7y/Jbjf66henym+9HQvRNSpkgxh1d 16Jt7a7QgZOFbiB/ZAa+8rkVNwtwBe9EfYYCgIge9xtOn+tf3tevKyup441xA2fBKzCN 9lGzzNxS1KFKDN58qB3sKij9HvWNOn1T/Z+YbL8S1gctwShy377JqgcYNTWKl3zrjAkb 9IIwpO/UzqxfWzg1/m9qfZObAXd3RRcijoTUALD+6iJXaMC70hCcXRGDYTrw3erMwpIE TBOVqud2k7EgD8/fQCg+SlHOxGb10hlMCmyoFmvZadib2aX10rzdjPrpakQ0Oga4ppyw XKPg== X-Gm-Message-State: APjAAAWYgdNYUFVfeixsoIl9mZMPF9RWBYJSugieAyPAUrpRf7M40An/ roG5dXVjhOQP3nIfXPegTRM= X-Received: by 2002:a65:56c1:: with SMTP id w1mr24171680pgs.395.1563160807339; Sun, 14 Jul 2019 20:20:07 -0700 (PDT) Received: from hfq-skylake.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.googlemail.com with ESMTPSA id j13sm14841634pgh.44.2019.07.14.20.20.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 14 Jul 2019 20:20:06 -0700 (PDT) From: Fuqian Huang Cc: Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Fuqian Huang Subject: [PATCH v3 22/24] tty: serial: Remove call to memset after pci_alloc_consistent Date: Mon, 15 Jul 2019 11:20:01 +0800 Message-Id: <20190715032001.7212-1-huangfq.daxian@gmail.com> X-Mailer: git-send-email 2.11.0 To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org pci_alloc_consistent calls dma_alloc_coherent directly. In commit 518a2f1925c3 ("dma-mapping: zero memory returned from dma_alloc_*"), dma_alloc_coherent has already zeroed the memory. So memset is not needed. Signed-off-by: Fuqian Huang --- Changes in v3: - Use actual commit rather than the merge commit in the commit message drivers/tty/serial/icom.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/tty/serial/icom.c b/drivers/tty/serial/icom.c index ad374f7c476d..624f3d541c68 100644 --- a/drivers/tty/serial/icom.c +++ b/drivers/tty/serial/icom.c @@ -207,8 +207,6 @@ static int get_port_memory(struct icom_port *icom_port) return -ENOMEM; } - memset(icom_port->statStg, 0, 4096); - /* FODs: Frame Out Descriptor Queue, this is a FIFO queue that indicates that frames are to be transmitted */ -- 2.11.0