Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 15 Jul 2019 02:05:40 -0400
From:   Paul Cercueil <paul@crapouillou.net>
Subject: Re: [PATCH] usb: musb: Disable pullup in gadget setup
To:     Bin Liu <b-liu@ti.com>
Cc:     od@zcrc.me, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Message-Id: <1563170740.1702.0@crapouillou.net>
In-Reply-To: <20190430150506.GF20993@uda0271908>
References: <20190404093743.6470-1-paul@crapouillou.net>
        <20190404161046.GA30182@uda0271908> <20190430150506.GF20993@uda0271908>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Bin,


Le mar. 30 avril 2019 =E0 11:05, Bin Liu <b-liu@ti.com> a =E9crit :
> Hi Paul,
>=20
> On Thu, Apr 04, 2019 at 11:10:46AM -0500, Bin Liu wrote:
>>  On Thu, Apr 04, 2019 at 11:37:43AM +0200, Paul Cercueil wrote:
>>  > The pullup may be already enabled before the driver is=20
>> initialized.
>>  > It has to be disabled at init time, as we cannot guarantee that a=20
>> gadget
>>  > driver will be bound to the UDC.
>>  >
>>  > Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>>  > ---
>>  >  drivers/usb/musb/musb_gadget.c | 1 +
>>  >  1 file changed, 1 insertion(+)
>>  >
>>  > diff --git a/drivers/usb/musb/musb_gadget.c=20
>> b/drivers/usb/musb/musb_gadget.c
>>  > index ffe462a657b1..094dc59c834c 100644
>>  > --- a/drivers/usb/musb/musb_gadget.c
>>  > +++ b/drivers/usb/musb/musb_gadget.c
>>  > @@ -1794,6 +1794,7 @@ int musb_gadget_setup(struct musb *musb)
>>  >
>>  >  	musb->is_active =3D 0;
>>  >  	musb_platform_try_idle(musb, 0);
>>  > +	musb_pullup(musb, 0);
>>  >
>>  >  	status =3D usb_add_gadget_udc(musb->controller, &musb->g);
>>  >  	if (status)
>>=20
>>  Applied.
>=20
> Sorry, I have dropped this patch from my tree. I realized the gadget
> core already defines callbacks to control the pullup. I think the
> proper fix should be calling usb_udc_vbus_handler() in musb gadget or
> glue layers.
>=20
> -Bin.

usb_udc_vbus_handler() requires a usb_gadget *, I don't see where I can
get that from the struct musb.

Besides, the point is to have the pullup disabled before a gadget is=20
bound,
so I don't understand why you suggest that?

-Paul

=