Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp3899077ybi; Mon, 15 Jul 2019 00:27:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqxIinGqT3MxQ2LE/W6ucC1XhjyIHlzRrImuyUPSqzPZ3gYlkifuxDWnEjGG9oRtmg5ZAStX X-Received: by 2002:a63:6f8f:: with SMTP id k137mr25383253pgc.90.1563175657800; Mon, 15 Jul 2019 00:27:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563175657; cv=none; d=google.com; s=arc-20160816; b=LohpYvMRtFH4g4kzl2O3jIVo3483SndfMkQLtvDh9QJx1WRlA1Uy597Fix/6lC3oLw ZC7b9QwDoTXLBWcJdGFPuRPCU1QYE/+2WtSG1mmp80geVRF/fPD2vQ+kZZI8LB4EINsW oJaIwjulX7VBFiuaBJfHPo1OgwppvtrRDFCsJbBoTIxdCdloqYFNzoN+bKJEi06w3zRk QThSfT+R4hLQRuxMKRwykCQDBpweEzub9LDLlRZvhNOkd5rDxjt/KKDKMZSYCr+73TaZ Ts+o7fGNzxDfbgoygiRTx/MU/bD3UvO3eVxjem2/G34RoO2Ub055y+J/GHn21tfZi22u dmZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=jOBXcDbTgSOAq5crokgRJAyQidDhNR3UPARtOSoycDI=; b=TXFedrDGWi8r982DOBq8diAVIRf36IdH9Dlqdqoc4+2WJGJGbGX3HWdl4CCMI+8GAS 2jwDAVgedGnZQQU8Y7QwDIsy1IFP5yWacI4NRcxjoC8wWcZaVWwkRyhzXCWvtzjK8mJK QmFNxmsvKHF3O/wprDkwNwj6b+aNM0607yJ94ooQifPbuBUyLTw3MHObhbcNvsZE09f4 ZkDLNfefdOQm2E4/xCR30hKaq4Yywy0rTiKLm3H9ESLH4jW53CEJPcUsaXoRa8FQyMp/ fPyJFrvy/srXMhE9CncOu5XZB+g8fWadSa8WxjBp/vInolRbdAIh6T34z+5W3siv5PdW HgAw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g98si15542256pje.92.2019.07.15.00.27.19; Mon, 15 Jul 2019 00:27:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729223AbfGOH1A (ORCPT + 99 others); Mon, 15 Jul 2019 03:27:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50174 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726170AbfGOH07 (ORCPT ); Mon, 15 Jul 2019 03:26:59 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E986E307D88D; Mon, 15 Jul 2019 07:26:57 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.43.17.136]) by smtp.corp.redhat.com (Postfix) with SMTP id A8A2F5D705; Mon, 15 Jul 2019 07:26:49 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Mon, 15 Jul 2019 09:26:57 +0200 (CEST) Date: Mon, 15 Jul 2019 09:26:48 +0200 From: Oleg Nesterov To: Joel Fernandes Cc: "Paul E. McKenney" , linux-kernel@vger.kernel.org, Alexey Kuznetsov , Bjorn Helgaas , Borislav Petkov , c0d1n61at3@gmail.com, "David S. Miller" , edumazet@google.com, Greg Kroah-Hartman , Hideaki YOSHIFUJI , "H. Peter Anvin" , Ingo Molnar , Jonathan Corbet , Josh Triplett , keescook@chromium.org, kernel-hardening@lists.openwall.com, kernel-team@android.com, Lai Jiangshan , Len Brown , linux-acpi@vger.kernel.org, linux-doc@vger.kernel.org, linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, Mathieu Desnoyers , neilb@suse.com, netdev@vger.kernel.org, Pavel Machek , peterz@infradead.org, "Rafael J. Wysocki" , Rasmus Villemoes , rcu@vger.kernel.org, Steven Rostedt , Tejun Heo , Thomas Gleixner , will@kernel.org, "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" Subject: Re: [PATCH v2 3/9] rcu/sync: Remove custom check for reader-section Message-ID: <20190715072648.GA1222@redhat.com> References: <20190712170024.111093-1-joel@joelfernandes.org> <20190712170024.111093-4-joel@joelfernandes.org> <20190712213559.GA175138@google.com> <20190712233206.GZ26519@linux.ibm.com> <20190713030150.GA246587@google.com> <20190713031008.GA248225@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190713031008.GA248225@google.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Mon, 15 Jul 2019 07:26:59 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/12, Joel Fernandes wrote: > > static inline bool rcu_sync_is_idle(struct rcu_sync *rsp) > { > - RCU_LOCKDEP_WARN(!rcu_read_lock_held() && > - !rcu_read_lock_bh_held() && > - !rcu_read_lock_sched_held(), > + RCU_LOCKDEP_WARN(!rcu_read_lock_any_held(), Yes, this is what I meant. Sorry for confusion, I should have mentioned that rcu_sync_is_idle() was recently updated when I suggested to use the new helper. Acked-by: Oleg Nesterov