Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp3953725ybi; Mon, 15 Jul 2019 01:28:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqzaiEb8H2J2H/KJCbGtEwt5jIuejSoQW+JF5ULjHuelaXi3rCgG2tqc4l7wCC/nyVU4tbD4 X-Received: by 2002:a17:902:a40c:: with SMTP id p12mr26968776plq.146.1563179331816; Mon, 15 Jul 2019 01:28:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563179331; cv=none; d=google.com; s=arc-20160816; b=nqCY/ajouJIGY1zvt3KmN/fdNG3GR1o9GqhD+X8mij0mgHjwnMjBy1MQtyYWkGJRWm 4p+1kCN7k9YkP4xtXvjIeSf/WztlcHmsYYxCpOpwa85LsvRG/Mf6uUsSiN1VMvYJFWpQ AvtaC9igKp9PEyFRjXfJaB4XZeHGfE4dFeGlMaBIf4l8ZMDyK1IV/o+BX0eeXbRSWHK6 aL6QeLwmllzTvwzjiaKGsobxcrXlI3KHN+x82HEoOVBcjS9S415X6WZZSijMZ98QiLhY o/HtfA3ncZT/84RIpCUe6ThN5TRpIo9Jg0nSTYK88PJmBMPow/kiGo6Z/fYWlrfqi+0T hm1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=u09pJZd1/LjgHkliwSWMTwxXiYSJx3iMCAmhbbplvKk=; b=grRAO/A1T6qtisKOYmj5q31W3qXOTNL8ltmVL14jF63JxHVpkARcve3GHLzGJ+YGc1 Zp+V3pxMCOvtaz1wG35Th4eWOCKHYgnCAUJ0qWuBXJkfccB/SVc7TpHDMWHzniOe8yMu 1e0eENBY4kx1IvZWflzXbl7T9NLBHVKSO2CIsth/+5Q6ZCwxCO1xt6jgU3xkxmffYWHT Hfz9C/VKSxwDnemG3q6vl1b28CrxNWbVnBMzzVdd0tsmHbHXWoNgOf9JBPm1Ea7+yQ83 dm/i7f1ily2OTbNIIrL1QgPnE+eI46Ef0/rJxqcFzx0ylnU8Rap7j9If5jvA7kpKCoV0 IgTQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e62si15872762pfh.254.2019.07.15.01.28.32; Mon, 15 Jul 2019 01:28:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729468AbfGOI1w (ORCPT + 99 others); Mon, 15 Jul 2019 04:27:52 -0400 Received: from mail.us.es ([193.147.175.20]:56836 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729302AbfGOI1v (ORCPT ); Mon, 15 Jul 2019 04:27:51 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id C8E78103249 for ; Mon, 15 Jul 2019 10:27:49 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id B9C635765B for ; Mon, 15 Jul 2019 10:27:49 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id ADFAED2F98; Mon, 15 Jul 2019 10:27:49 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id A44971150CB; Mon, 15 Jul 2019 10:27:47 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Mon, 15 Jul 2019 10:27:47 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (sys.soleta.eu [212.170.55.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 6F93A4265A2F; Mon, 15 Jul 2019 10:27:47 +0200 (CEST) Date: Mon, 15 Jul 2019 10:27:47 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Simon Horman Cc: yangxingwu , wensong@linux-vs.org, ja@ssi.bg, kadlec@blackhole.kfki.hu, fw@strlen.de, davem@davemloft.net, netdev@vger.kernel.org, lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ipvs: remove unnecessary space Message-ID: <20190715082747.fdlpvekbqyhwx724@salvia> References: <20190710074552.74394-1-xingwu.yang@gmail.com> <20190710080609.smxjqe2d5jyro4hv@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190710080609.smxjqe2d5jyro4hv@verge.net.au> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 10, 2019 at 10:06:09AM +0200, Simon Horman wrote: > On Wed, Jul 10, 2019 at 03:45:52PM +0800, yangxingwu wrote: > > --- > > net/netfilter/ipvs/ip_vs_mh.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/net/netfilter/ipvs/ip_vs_mh.c b/net/netfilter/ipvs/ip_vs_mh.c > > index 94d9d34..98e358e 100644 > > --- a/net/netfilter/ipvs/ip_vs_mh.c > > +++ b/net/netfilter/ipvs/ip_vs_mh.c > > @@ -174,8 +174,8 @@ static int ip_vs_mh_populate(struct ip_vs_mh_state *s, > > return 0; > > } > > > > - table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE), > > - sizeof(unsigned long), GFP_KERNEL); > > + table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE), > > + sizeof(unsigned long), GFP_KERNEL); May I ask one thing? :-) Please, remove all unnecessary spaces in one go, search for: git grep "= " in the netfilter tree, and send a v2 for this one. Thanks.