Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\))
Subject: Re: [PATCH BUGFIX IMPROVEMENT 1/1] block, bfq: check also in-flight
 I/O in dispatch plugging
From:   Paolo Valente <paolo.valente@linaro.org>
In-Reply-To: <2c15c4bc-145d-fb0d-ae5a-2a8ce36f977b@applied-asynchrony.com>
Date:   Mon, 15 Jul 2019 12:53:38 +0200
Cc:     Jens Axboe <axboe@kernel.dk>,
        linux-block <linux-block@vger.kernel.org>,
        kernel list <linux-kernel@vger.kernel.org>,
        Ulf Hansson <ulf.hansson@linaro.org>, linus.walleij@linaro.org,
        bfq-iosched@googlegroups.com, oleksandr@natalenko.name
Content-Transfer-Encoding: quoted-printable
Message-Id: <B064EF63-B7F6-4BA3-BA0A-FF9579893971@linaro.org>
References: <20190715093153.19821-1-paolo.valente@linaro.org>
 <20190715093153.19821-2-paolo.valente@linaro.org>
 <88e3c1e1-224f-a9a8-0875-848ba23b6fbf@applied-asynchrony.com>
 <B0406DB0-1003-4610-8A75-F3D7614C616E@linaro.org>
 <2c15c4bc-145d-fb0d-ae5a-2a8ce36f977b@applied-asynchrony.com>
To:     =?utf-8?Q?Holger_Hoffst=C3=A4tte?= <holger@applied-asynchrony.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Ops, my fault of course. I submitted the patch I made on top of the dev =
version of bfq. Preparing a V2. Sorry.

> Il giorno 15 lug 2019, alle ore 12:49, Holger Hoffst=C3=A4tte =
<holger@applied-asynchrony.com> ha scritto:
>=20
> On 7/15/19 12:18 PM, Paolo Valente wrote:
>> Didn't I simply move it forward in that commit?
>>> Il giorno 15 lug 2019, alle ore 12:16, Holger Hoffst=C3=A4tte =
<holger@applied-asynchrony.com> ha scritto:
>>> Paolo,
>>>=20
>>> The function idling_needed_for_service_guarantees() was just removed =
in 5.3-commit
>>> 3726112ec731 ("block, bfq: re-schedule empty queues if they deserve =
I/O plugging").
>=20
> Argh, sorry - yes you did, it failed to apply because the =
asymmetric_scenario
> variable was already gone. Fixing the patch to just return the =
expression so that
> it matches 3726112ec731 worked.
>=20
> All good!
> Holger